From: Zhao Liu <zhao1.liu@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-rust@nongnu.org, tanishdesai37@gmail.com
Subject: Re: [PATCH 2/2] rust: move rust.bindgen to qemu-api crate
Date: Fri, 20 Jun 2025 23:10:11 +0800 [thread overview]
Message-ID: <aFV507NQPwVISgBD@intel.com> (raw)
In-Reply-To: <20250613130249.1225545-3-pbonzini@redhat.com>
On Fri, Jun 13, 2025 at 03:02:49PM +0200, Paolo Bonzini wrote:
> Date: Fri, 13 Jun 2025 15:02:49 +0200
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH 2/2] rust: move rust.bindgen to qemu-api crate
> X-Mailer: git-send-email 2.49.0
>
> Once qemu-api is split in multiple crates, each of which will have
> its own invocation of bindgen. There cannot be only one, because
> there are occasional "impl" blocks for the bindgen-generated
> structs (e.g. VMStateFlags or QOM classes) that have to
> reside in the same crate as the bindgen-generated code.
>
> For now, prepare for this new organization by invoking bindgen
> within the qemu-api crate's build definitions.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> meson.build | 41 -----------------------------------
> rust/{ => qemu-api}/wrapper.h | 0
> rust/meson.build | 4 +++-
> rust/qemu-api/meson.build | 41 +++++++++++++++++++++++++++++++++++
> 4 files changed, 44 insertions(+), 42 deletions(-)
> rename rust/{ => qemu-api}/wrapper.h (100%)
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
prev parent reply other threads:[~2025-06-20 14:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 13:02 [PATCH 0/2] rust: prepare for multiple bindgen invocations Paolo Bonzini
2025-06-13 13:02 ` [PATCH 1/2] rust: prepare variable definitions " Paolo Bonzini
2025-06-20 10:07 ` Zhao Liu
2025-06-13 13:02 ` [PATCH 2/2] rust: move rust.bindgen to qemu-api crate Paolo Bonzini
2025-06-20 15:10 ` Zhao Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFV507NQPwVISgBD@intel.com \
--to=zhao1.liu@intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
--cc=tanishdesai37@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.