From: Danilo Krummrich <dakr@kernel.org>
To: Igor Korotin <igor.korotin.linux@gmail.com>
Cc: ojeda@kernel.org, Rob Herring <robh@kernel.org>,
alex.gaynor@gmail.com, rafael@kernel.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org, linux-acpi@vger.kernel.org,
boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com,
benno.lossin@proton.me, a.hindborg@kernel.org,
aliceryhl@google.com, tmgross@umich.edu, lenb@kernel.org,
wedsonaf@gmail.com, viresh.kumar@linaro.org, alex.hung@amd.com,
dingxiangfei2009@gmail.com
Subject: Re: [PATCH v7 3/9] samples: rust: platform: conditionally call Self::properties_parse()
Date: Fri, 20 Jun 2025 13:56:05 +0200 [thread overview]
Message-ID: <aFVMVcYm0JwI5L6l@cassiopeiae> (raw)
In-Reply-To: <ddcdc5ac-9c6f-4aca-ad66-37e1e66ef740@gmail.com>
On Fri, Jun 20, 2025 at 12:30:37PM +0100, Igor Korotin wrote:
> Just to make sure that we're on the same page, I replace this:
>
> if dev.fwnode().is_some_and(|node|
> node.is_compatible(c_str!("test,rust-device")))
>
> with:
>
> if dev.fwnode().is_some_and(|node| node.is_of_node())
>
> And reworded the comment as follows:
>
> samples: rust: platform: conditionally call Self::properties_parse()
>
> Only call Self::properties_parse() when the device is OF node
>
> Once we add ACPI support, we don't want the ACPI device to fail probing
> in Self::properties_parse().
LGTM!
next prev parent reply other threads:[~2025-06-20 11:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 10:02 [PATCH v7 0/9] rust: Add ACPI match table support for Rust drivers Igor Korotin
2025-06-18 10:06 ` [PATCH v7 1/9] rust: device: implement FwNode::is_compatible() Igor Korotin
2025-06-18 10:11 ` [PATCH v7 2/9] samples: rust: platform: don't call as_ref() repeatedly Igor Korotin
2025-06-18 10:13 ` [PATCH v7 3/9] samples: rust: platform: conditionally call Self::properties_parse() Igor Korotin
2025-06-18 13:19 ` Rob Herring
2025-06-18 14:11 ` Danilo Krummrich
2025-06-19 17:59 ` Danilo Krummrich
2025-06-20 11:30 ` Igor Korotin
2025-06-20 11:56 ` Danilo Krummrich [this message]
2025-06-18 10:15 ` [PATCH v7 4/9] rust: acpi: add `acpi::DeviceId` abstraction Igor Korotin
2025-06-18 10:17 ` [PATCH v7 5/9] rust: driver: Consolidate `Adapter::of_id_info` methods using `#[cfg]` Igor Korotin
2025-06-18 10:19 ` [PATCH v7 6/9] rust: driver: Add ACPI id table support to Adapter trait Igor Korotin
2025-06-18 10:22 ` [PATCH v7 7/9] rust: platform: Set `OF_ID_TABLE` default to `None` in `Driver` trait Igor Korotin
2025-06-18 10:24 ` [PATCH v7 8/9] rust: platform: Add ACPI match table support to " Igor Korotin
2025-06-18 10:26 ` [PATCH v7 9/9] samples: rust: add ACPI match table example to platform driver Igor Korotin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFVMVcYm0JwI5L6l@cassiopeiae \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=alex.hung@amd.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dingxiangfei2009@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=igor.korotin.linux@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=viresh.kumar@linaro.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.