Re: Issue in the patch "ata: ahci: Disallow LPM for ASUSPRO-D840SA motherboard"

[Niklas Cassel <cassel@kernel.org>]

+linux-ide

Hello Andy,

On Sat, Jun 21, 2025 at 06:06:10PM +0000, Andy Yang wrote:
> Hi Damien & Niklas,
> 
> This patch isn't working. I've mentioned this in several previous emails as
> replies, from the time it was applied to the libata work tree to its being
> merged into stable. This is my third email addressing this issue.

This is the first email that I see about this issue.

I also don't find any other report about this on the mailing list,
perhaps you were sending your email using HTML instead of plain text?


> 
>  The DMI_PRODUCT_VERSION field is incorrect, we should consider using
> DMI_MATCH(DMI_PRODUCT_NAME,
> "ASUSPRO D840MB_M840SA") or DMI_MATCH(DMI_BOARD_NAME, "D840MB") instead. If
> you require additional DMI information about this model, I included it in a
> previous reply to the patch mailing list.


Does this patch solve your problem:

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index e5e5c2e81d09..aa93b0ecbbc6 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1450,7 +1450,7 @@ static bool ahci_broken_lpm(struct pci_dev *pdev)
 		{
 			.matches = {
 				DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
-				DMI_MATCH(DMI_PRODUCT_VERSION, "ASUSPRO D840MB_M840SA"),
+				DMI_MATCH(DMI_PRODUCT_NAME, "ASUSPRO D840MB_M840SA"),
 			},
 			/* 320 is broken, there is no known good version. */
 		},



Kind regards,
Niklas