From: Christoph Hellwig <hch@infradead.org>
To: Anuj Gupta <anuj20.g@samsung.com>
Cc: vincent.fu@samsung.com, jack@suse.cz, anuj1072538@gmail.com,
axboe@kernel.dk, viro@zeniv.linux.org.uk, brauner@kernel.org,
hch@infradead.org, martin.petersen@oracle.com,
ebiggers@kernel.org, adilger@dilger.ca,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
joshi.k@samsung.com, linux-nvme@lists.infradead.org,
linux-scsi@vger.kernel.org, gost.dev@samsung.com
Subject: Re: [PATCH for-next v4 1/4] block: rename tuple_size field in blk_integrity to metadata_size
Date: Sun, 22 Jun 2025 22:29:33 -0700 [thread overview]
Message-ID: <aFjmPan6bmE8Vh1b@infradead.org> (raw)
In-Reply-To: <20250618055153.48823-2-anuj20.g@samsung.com>
On Wed, Jun 18, 2025 at 11:21:50AM +0530, Anuj Gupta wrote:
> @@ -299,7 +299,7 @@ static blk_status_t ext_pi_crc64_verify(struct blk_integrity_iter *iter,
> static void ext_pi_type1_prepare(struct request *rq)
> {
> struct blk_integrity *bi = &rq->q->limits.integrity;
> - const int tuple_sz = bi->tuple_size;
> + const int tuple_sz = bi->metadata_size;
I guess keeping tuple here is fine because we're deep into PI code.
The rest looks good as well:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-06-23 5:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250618055210epcas5p397b5ca1dc472e3008af707391a5fa628@epcas5p3.samsung.com>
2025-06-18 5:51 ` [PATCH for-next v4 0/4] add ioctl to query metadata and protection info capabilities Anuj Gupta
2025-06-18 5:51 ` [PATCH for-next v4 1/4] block: rename tuple_size field in blk_integrity to metadata_size Anuj Gupta
2025-06-23 5:29 ` Christoph Hellwig [this message]
2025-06-18 5:51 ` [PATCH for-next v4 2/4] block: introduce pi_tuple_size field in blk_integrity Anuj Gupta
2025-06-18 5:51 ` [PATCH for-next v4 3/4] set pi_offset only when checksum type is not BLK_INTEGRITY_CSUM_NONE Anuj Gupta
2025-06-23 5:30 ` Christoph Hellwig
2025-06-18 5:51 ` [PATCH for-next v4 4/4] fs: add ioctl to query metadata and protection info capabilities Anuj Gupta
2025-06-23 5:32 ` Christoph Hellwig
2025-06-23 1:33 ` [PATCH for-next v4 0/4] " Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFjmPan6bmE8Vh1b@infradead.org \
--to=hch@infradead.org \
--cc=adilger@dilger.ca \
--cc=anuj1072538@gmail.com \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=ebiggers@kernel.org \
--cc=gost.dev@samsung.com \
--cc=jack@suse.cz \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=vincent.fu@samsung.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.