From: Christoph Hellwig <hch@infradead.org>
To: Sergey Bashirov <sergeybashirov@gmail.com>
Cc: Chuck Lever <chuck.lever@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
Jeff Layton <jlayton@kernel.org>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Konstantin Evtushenko <koevtushenko@yandex.com>
Subject: Re: [PATCH v4 2/2] nfsd: Implement large extent array support in pNFS
Date: Mon, 23 Jun 2025 00:41:19 -0700 [thread overview]
Message-ID: <aFkFHw0BcRO1i2bG@infradead.org> (raw)
In-Reply-To: <20250621165409.147744-3-sergeybashirov@gmail.com>
On Sat, Jun 21, 2025 at 07:52:45PM +0300, Sergey Bashirov wrote:
> + memcpy(&rqstp->rq_arg, &lcp->lc_up_layout, sizeof(struct xdr_buf));
Nit: using a struct assignment like:
rqstp->rq_arg = lcp->lc_up_layout;
might be a tad bettet due to type safety here.
> + memcpy(&rqstp->rq_arg, &lcp->lc_up_layout, sizeof(struct xdr_buf));
Same here.
Otherwise this looks good to me (but I'm not the best reviwer for XDR
code :)):
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-06-23 7:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-21 16:52 [PATCH v4 0/2] nfsd: Implement large extent array support in pNFS Sergey Bashirov
2025-06-21 16:52 ` [PATCH v4 1/2] nfsd: Drop dprintk in blocklayout xdr functions Sergey Bashirov
2025-06-21 18:46 ` Jeff Layton
2025-06-23 7:34 ` Christoph Hellwig
2025-06-21 16:52 ` [PATCH v4 2/2] nfsd: Implement large extent array support in pNFS Sergey Bashirov
2025-06-21 19:08 ` Jeff Layton
2025-06-23 7:41 ` Christoph Hellwig [this message]
2025-06-23 13:50 ` [PATCH v4 0/2] " Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFkFHw0BcRO1i2bG@infradead.org \
--to=hch@infradead.org \
--cc=Dai.Ngo@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=koevtushenko@yandex.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=sergeybashirov@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.