From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lothar Rubusch <l.rubusch@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
corbet@lwn.net, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
eraretuya@gmail.com
Subject: Re: [PATCH v10 1/7] iio: accel: adxl345: simplify interrupt mapping
Date: Mon, 23 Jun 2025 12:24:53 +0300 [thread overview]
Message-ID: <aFkdZVD4j31QZ0eD@smile.fi.intel.com> (raw)
In-Reply-To: <20250622155010.164451-2-l.rubusch@gmail.com>
On Sun, Jun 22, 2025 at 03:50:04PM +0000, Lothar Rubusch wrote:
> Refactor the sensor interrupt mapping by utilizing regmap_assign_bits(),
> which accepts a boolean value directly. Introduce a helper function to
> streamline the identification of the configured interrupt line pin. Also,
> use identifiers from units.h to represent the full 8-bit register when
> setting bits.
>
> This is a purely refactoring change and does not affect functionality.
> +static int _get_int_line(struct device *dev, int *irq)
Oh, I should have been clear, I meant the suffix of the name, one still needs
a namespace for this: adxl345_get_int_line().
With that fixed,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-23 9:25 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-22 15:50 [PATCH v10 0/7] iio: accel: adxl345: add interrupt based sensor events Lothar Rubusch
2025-06-22 15:50 ` [PATCH v10 1/7] iio: accel: adxl345: simplify interrupt mapping Lothar Rubusch
2025-06-23 9:24 ` Andy Shevchenko [this message]
2025-06-22 15:50 ` [PATCH v10 2/7] iio: accel: adxl345: simplify reading the FIFO Lothar Rubusch
2025-06-22 15:50 ` [PATCH v10 3/7] iio: accel: adxl345: add activity event feature Lothar Rubusch
2025-06-23 9:34 ` Andy Shevchenko
2025-06-23 20:57 ` Lothar Rubusch
2025-06-24 7:28 ` Andy Shevchenko
2025-06-28 16:05 ` Jonathan Cameron
2025-06-22 15:50 ` [PATCH v10 4/7] iio: accel: adxl345: add inactivity feature Lothar Rubusch
2025-06-23 9:44 ` Andy Shevchenko
2025-06-23 21:06 ` Lothar Rubusch
2025-06-24 7:33 ` Andy Shevchenko
2025-06-24 8:27 ` Lothar Rubusch
2025-06-28 16:08 ` Jonathan Cameron
2025-06-28 21:10 ` Lothar Rubusch
2025-06-29 7:30 ` Andy Shevchenko
2025-06-29 16:28 ` Jonathan Cameron
2025-06-22 15:50 ` [PATCH v10 5/7] iio: accel: adxl345: add coupling detection for activity/inactivity Lothar Rubusch
2025-06-23 10:11 ` Andy Shevchenko
2025-06-22 15:50 ` [PATCH v10 6/7] iio: accel: adxl345: extend inactivity time for less than 1s Lothar Rubusch
2025-06-23 10:17 ` Andy Shevchenko
2025-06-23 21:21 ` Lothar Rubusch
2025-06-24 7:37 ` Andy Shevchenko
2025-06-24 8:18 ` Lothar Rubusch
2025-06-24 8:36 ` Andy Shevchenko
2025-06-22 15:50 ` [PATCH v10 7/7] docs: iio: add documentation for adxl345 driver Lothar Rubusch
2025-06-28 16:17 ` Jonathan Cameron
2025-06-23 9:45 ` [PATCH v10 0/7] iio: accel: adxl345: add interrupt based sensor events Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFkdZVD4j31QZ0eD@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=corbet@lwn.net \
--cc=dlechner@baylibre.com \
--cc=eraretuya@gmail.com \
--cc=jic23@kernel.org \
--cc=l.rubusch@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.