From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] evaluate: refuse to merge set and map
Date: Mon, 23 Jun 2025 21:39:17 +0200 [thread overview]
Message-ID: <aFmtZfDQeObDuZ-q@strlen.de> (raw)
In-Reply-To: <aFl_HmQG7vJZ1u9O@calendula>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> static inline bool set_is_map(uint32_t set_flags)
> {
> return set_is_datamap(set_flags) || set_is_objmap(set_flags);
> }
>
> then, I'd suggest
>
> if (set_is_datamap(existing_set->flags) != set_is_datamap(set->flags))
> ...
> if (set_is_objmap(existing_set->flags) != set_is_objmap(set->flags))
> ...
>
> Thanks.
Right, I sent a v2 that checks both map flavours.
prev parent reply other threads:[~2025-06-23 19:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 13:22 [PATCH nft] evaluate: refuse to merge set and map Florian Westphal
2025-06-23 16:21 ` Pablo Neira Ayuso
2025-06-23 19:39 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFmtZfDQeObDuZ-q@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.