From: dmkhn@proton.me
To: "Orzel, Michal" <michal.orzel@amd.com>
Cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com,
anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org,
oleksii.kurochko@gmail.com, roger.pau@citrix.com,
sstabellini@kernel.org, dmukhin@ford.com
Subject: Re: [PATCH v1 01/16] arm/vpl011: rename virtual PL011 Kconfig option
Date: Tue, 24 Jun 2025 07:24:48 +0000 [thread overview]
Message-ID: <aFpSvMzxrNrgQEVB@kraken> (raw)
In-Reply-To: <da16500d-f589-4396-8ad6-78cdb443da60@amd.com>
On Tue, Jun 24, 2025 at 08:13:08AM +0200, Orzel, Michal wrote:
>
>
> On 24/06/2025 05:55, dmkhn@proton.me wrote:
> > From: Denis Mukhin <dmukhin@ford.com>
> >
> > Rename CONFIG_SBSA_VUART_CONSOLE to CONFIG_HAS_VUART_PL011.
> Why? We emulate SBSA UART and not PL011. Despite the similarities (the former is
> a subset of the latter) they are not the same. I find it confusing and drivers
> for PL011 might not work with SBSA UART. Also, in the future we may want to
> emulate full PL011 in which case it will be even more confusing.
That's because the emulator is called vpl011, but yes, it is SBSA UART.
I will adjust to SBSA, thanks!
>
> Also, why HAS_?
My understanding is that HAS_ is the desired naming convention throughout the
code (not documented, though), e.g. all Arm UART drivers are gated by HAS_XXX
(e.g. arch/arm/platforms/Kconfig).
>
> ~Michal
>
next prev parent reply other threads:[~2025-06-24 7:25 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 3:54 [PATCH v1 00/16] xen: framework for UART emulators dmkhn
2025-06-24 3:55 ` [PATCH v1 01/16] arm/vpl011: rename virtual PL011 Kconfig option dmkhn
2025-06-24 6:13 ` Orzel, Michal
2025-06-24 7:24 ` dmkhn [this message]
2025-07-17 15:43 ` Alejandro Vallejo
2025-07-17 19:58 ` dmkhn
2025-07-18 11:10 ` Alejandro Vallejo
2025-06-24 3:55 ` [PATCH v1 02/16] arm/vpl011: move DT node parsing to PL011 emulator code dmkhn
2025-06-24 7:49 ` Orzel, Michal
2025-06-24 21:56 ` dmkhn
2025-06-25 6:57 ` Orzel, Michal
2025-07-31 21:02 ` dmkhn
2025-06-24 3:55 ` [PATCH v1 03/16] arm/vpl011: use vuart_ prefix in vpl011 public calls dmkhn
2025-06-24 10:11 ` Orzel, Michal
2025-06-24 22:17 ` dmkhn
2025-07-31 21:11 ` dmkhn
2025-06-24 3:55 ` [PATCH v1 04/16] arm/vpl011: use raw spin_lock_{irqrestore,irqsave} dmkhn
2025-06-24 5:46 ` Jan Beulich
2025-06-24 7:50 ` Orzel, Michal
2025-06-24 21:46 ` dmkhn
2025-06-25 6:52 ` Orzel, Michal
2025-07-31 21:03 ` dmkhn
2025-06-24 3:55 ` [PATCH v1 05/16] arm/vpl011: use void pointer in domain struct dmkhn
2025-06-25 7:21 ` Orzel, Michal
2025-06-24 3:55 ` [PATCH v1 06/16] arm/vpl011: remove vpl011 header file dmkhn
2025-06-24 3:55 ` [PATCH v1 07/16] arm/vuart: rename 'virtual UART' Kconfig option dmkhn
2025-06-24 6:37 ` Orzel, Michal
2025-06-24 7:14 ` dmkhn
2025-06-25 7:07 ` Orzel, Michal
2025-07-31 21:02 ` dmkhn
2025-06-24 3:56 ` [PATCH v1 08/16] arm/vuart: move simple MMIO-based vUART declarations to common header dmkhn
2025-06-24 3:56 ` [PATCH v1 09/16] arm/vuart: use void pointer in domain struct dmkhn
2025-06-24 3:56 ` [PATCH v1 10/16] arm/vuart: merge vuart_print_char() with vuart_mmio_write() dmkhn
2025-06-24 3:56 ` [PATCH v1 11/16] xen/domain: introduce common emulation flags dmkhn
2025-06-24 3:56 ` [PATCH v1 12/16] xen/domain: introduce domain-emu.h dmkhn
2025-07-09 14:57 ` Jan Beulich
2025-07-31 20:55 ` dmkhn
2025-08-01 6:02 ` Jan Beulich
2025-08-01 19:30 ` dmkhn
2025-08-04 7:13 ` Jan Beulich
2025-08-05 0:24 ` dmkhn
2025-06-24 3:56 ` [PATCH v1 13/16] drivers/vuart: move PL011 emulator code dmkhn
2025-06-24 5:50 ` Jan Beulich
2025-06-24 7:31 ` dmkhn
2025-06-24 7:33 ` Jan Beulich
2025-07-10 1:59 ` dmkhn
2025-07-10 8:15 ` Jan Beulich
2025-07-10 17:00 ` Stefano Stabellini
2025-07-31 20:47 ` dmkhn
2025-07-10 18:32 ` dmkhn
2025-06-24 3:57 ` [PATCH v1 14/16] drivers/vuart: move simple MMIO-based UART emulator dmkhn
2025-06-24 5:53 ` Jan Beulich
2025-06-24 7:36 ` dmkhn
2025-06-24 7:40 ` Jan Beulich
2025-06-24 22:54 ` dmkhn
2025-06-25 5:25 ` Jan Beulich
2025-07-10 1:52 ` dmkhn
2025-06-24 3:57 ` [PATCH v1 15/16] drivers/vuart: introduce framework for UART emulators dmkhn
2025-06-24 3:57 ` [PATCH v1 16/16] drivers/vuart: hook simple MMIO-based UART to vUART framework dmkhn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFpSvMzxrNrgQEVB@kraken \
--to=dmkhn@proton.me \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=dmukhin@ford.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=oleksii.kurochko@gmail.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.