From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Lukas Wunner" <lukas@wunner.de>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Andy Shevchenko" <andy@kernel.org>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org
Subject: Re: [PATCH v15 1/2] math.h: provide rounddown_ull variant for rounddown MACRO
Date: Tue, 24 Jun 2025 11:40:58 +0300 [thread overview]
Message-ID: <aFpkmjlc-14xxkn4@smile.fi.intel.com> (raw)
In-Reply-To: <685a5787.050a0220.20ff0f.fd7a@mx.google.com>
On Tue, Jun 24, 2025 at 09:45:08AM +0200, Christian Marangi wrote:
> On Tue, Jun 24, 2025 at 09:08:32AM +0300, Andy Shevchenko wrote:
> > On Tue, Jun 24, 2025 at 12:11 AM Christian Marangi <ansuelsmth@gmail.com> wrote:
...
> > rounddown(),
>
> For this and the other... Is it correct to use () for MACRO?
> I assume () should be used only for functions.
When it takes argument, yes. When it doesn't then you don't put it.
...
> > rounddown_ull()
Btw, I don't like name for this, it's better to be in math64 with the u64 or similar suffixes like it's used for div/mul variants.
Also add a roundup to make the API symmetrical (yes, it's okay that it has no
users, it's a macro and doesn't consume memory at run-time).
...
> > > - Add this patch
> >
> > Why are math64 APIs not usable here?
>
> There isn't a rounddown API for math64.
Then implementing it there (in math64.h) looks to me natural thingy that will
implicitly suggest this.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-24 8:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 21:11 [PATCH v15 1/2] math.h: provide rounddown_ull variant for rounddown MACRO Christian Marangi
2025-06-23 21:11 ` [PATCH v15 2/2] pwm: airoha: Add support for EN7581 SoC Christian Marangi
2025-06-24 6:37 ` Andy Shevchenko
2025-06-24 8:41 ` Christian Marangi
2025-06-24 13:05 ` Andy Shevchenko
2025-06-24 6:08 ` [PATCH v15 1/2] math.h: provide rounddown_ull variant for rounddown MACRO Andy Shevchenko
2025-06-24 7:45 ` Christian Marangi
2025-06-24 8:40 ` Andy Shevchenko [this message]
2025-06-24 8:44 ` Andy Shevchenko
2025-06-24 8:48 ` Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFpkmjlc-14xxkn4@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.