From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60945C77B7C for ; Tue, 24 Jun 2025 14:35:54 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1023795.1399858 (Exim 4.92) (envelope-from ) id 1uU4kM-0000wz-59; Tue, 24 Jun 2025 14:35:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1023795.1399858; Tue, 24 Jun 2025 14:35:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uU4kM-0000ws-1X; Tue, 24 Jun 2025 14:35:38 +0000 Received: by outflank-mailman (input) for mailman id 1023795; Tue, 24 Jun 2025 14:35:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uU4kK-0000wk-F1 for xen-devel@lists.xenproject.org; Tue, 24 Jun 2025 14:35:36 +0000 Received: from fhigh-b6-smtp.messagingengine.com (fhigh-b6-smtp.messagingengine.com [202.12.124.157]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7c5c4bcb-5108-11f0-a30f-13f23c93f187; Tue, 24 Jun 2025 16:35:34 +0200 (CEST) Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfhigh.stl.internal (Postfix) with ESMTP id 262FF7A01B1; Tue, 24 Jun 2025 10:35:33 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Tue, 24 Jun 2025 10:35:33 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 24 Jun 2025 10:35:31 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c5c4bcb-5108-11f0-a30f-13f23c93f187 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1750775733; x=1750862133; bh=1o5WLUPC3/xWp3VpukBP3ELtP/YYgjUGaXyyigzAvT4=; b= SUBlFZQRi+yj7t7+jhRcQEu1eUUnkm8zWZtY9bCwZ/HvJkuWu1OFZp+uI3ojTGpQ +Q3V3unEX0StNZtk5cDgJI9+MUmwEUEF+OUzJ/n8OBP8dbNvO3WIz6twSKfhanOM vhjBsaAT9vb0YB87QXspSstvjTev3vpR6FJD5xiQMEYAtjggbVrkur/uq92Zg1SU JD26Di5lNBYfRzlQwZC7FCM9wRaWg71jtmMUusGpQxEQNIBTPjukvfXXT9OoKKgx 3OBAn8oj0/5DrVyYVqwYUSWBFYtgn7Nf+GWJ4yZs4OOZS2sF7d4XEYsWrYPlhub5 6JoGgEizoiVPJQaVVJ+kZw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1750775733; x=1750862133; bh=1o5WLUPC3/xWp3VpukBP3ELtP/YYgjUGaXy yigzAvT4=; b=FcnNIE72P7bk8abj8OvGrhFvErc98NYBgLiNMZyUXScMTjfo5Lt Dy0/+JbXyRpsaXPKoNjAB83/5kQLKK8NY3PktrMDFWcA/ggKh0uYgQHO/DE/MCPJ SfKDkM6ghdqLJg+VJe7/25gGiRm980u/AzHmloNoklPvGRL7Y9M+Dyzq+Wem7d6M g8EvZUI8SbGR63o6S6cYrG9/ZKXU61cyIvKEkvieCTZyu7qoqhFJ0IyX9q2HnqNl EQtMpbdOgyAmVPLkSwLOGc4I92Xqf0prdZtDkW5vtbq5NMIoaerWGmvx6i3UnG66 7ukD6CHdfID4ogvH+j7WIVAALEkmqr1uGDg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddvgddvtddugecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghkucfo rghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvhhish hisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefgudelteef vefhfeehieetleeihfejhfeludevteetkeevtedtvdegueetfeejudenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhn vhhishhisghlvghthhhinhhgshhlrggsrdgtohhmpdhnsggprhgtphhtthhopeegpdhmoh guvgepshhmthhpohhuthdprhgtphhtthhopehfrhgvughirghnohdriihighhlihhosegt lhhouhgurdgtohhmpdhrtghpthhtohepgigvnhdquggvvhgvlheslhhishhtshdrgigvnh hprhhojhgvtghtrdhorhhgpdhrtghpthhtohepughpshhmihhthhesrghpvghrthhushhs ohhluhhtihhonhhsrdgtohhmpdhrtghpthhtohepjhgsvghulhhitghhsehsuhhsvgdrtg homh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Tue, 24 Jun 2025 16:35:29 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Frediano Ziglio Cc: xen-devel@lists.xenproject.org, "Daniel P. Smith" , Jan Beulich Subject: Re: [PATCH 1/2] xen/efi: Handle cases where file didn't come from ESP Message-ID: References: <20250624083157.9334-1-frediano.ziglio@cloud.com> <20250624083157.9334-2-frediano.ziglio@cloud.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NsN83TDdGENhcKex" Content-Disposition: inline In-Reply-To: --NsN83TDdGENhcKex Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 24 Jun 2025 16:35:29 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Frediano Ziglio Cc: xen-devel@lists.xenproject.org, "Daniel P. Smith" , Jan Beulich Subject: Re: [PATCH 1/2] xen/efi: Handle cases where file didn't come from ESP On Tue, Jun 24, 2025 at 03:05:25PM +0100, Frediano Ziglio wrote: > OT: the flow of read_file (specifically "what" handling) looks > weird... can I change it? It tries to avoid duplication of PrintErr calls, while including what failed in the error message. Looks like somebody really wanted to avoid using goto here... Sure, if you want to clean it up go ahead. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --NsN83TDdGENhcKex Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmhat7EACgkQ24/THMrX 1yyKagf/T4PHyxHMgK22dMs0mphUEBQAF4V0+GhogN9r+coPIbAcK3q76HzWvfNK B2ipZkOjLI3Tb4QM8xHr4oLybpQkxGK2X8N+jy8wXR6sf3PdccNgeW62rzUcQr2S NMX2McS3Lfyrp2sZMBs+OsT85m6ZEjcFrrbA/7BVRKlVvtcmCxw24ih7iDhN25AQ ODFuiB9+jK9tZpjv2jLxRZyorTWwXruLjt3sLOMgwqcwgSPpgmcrBfDioC4eLs2h uyyOIOP+pRbsiqjJhlJLEhiG7WJVhEGUvEQ0iIM8OsVbEeXS6MVk3+VY4sA9u6zO +PMpkT9DM3A8qrNpL0DR86hLFklqHA== =8XvQ -----END PGP SIGNATURE----- --NsN83TDdGENhcKex--