From: Oscar Salvador <osalvador@suse.de>
To: David Hildenbrand <david@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Muchun Song <muchun.song@linux.dev>, Peter Xu <peterx@redhat.com>,
Gavin Guo <gavinguo@igalia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/5] mm,hugetlb: Rename anon_rmap to new_anon_folio and make it boolean
Date: Wed, 25 Jun 2025 09:43:21 +0200 [thread overview]
Message-ID: <aFuomf97EUK2YJDJ@localhost.localdomain> (raw)
In-Reply-To: <7f8ac35d-89f0-41e7-acfb-bcf54991612e@redhat.com>
On Mon, Jun 23, 2025 at 04:13:17PM +0200, David Hildenbrand wrote:
> > - if (new_folio && !new_pagecache_folio)
> > + /* We only need to restore reservations for private mappings */
> > + if (new_folio && new_anon_folio)
>
> Could this be simplified to
>
> if (new_anon_folio) {
Yes, definitely, will do in the next version.
--
Oscar Salvador
SUSE Labs
next prev parent reply other threads:[~2025-06-25 7:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 12:30 [PATCH v2 0/5] Misc rework on hugetlb faulting path Oscar Salvador
2025-06-20 12:30 ` [PATCH v2 1/5] mm,hugetlb: Change mechanism to detect a COW on private mapping Oscar Salvador
2025-06-23 14:09 ` David Hildenbrand
2025-06-25 7:49 ` Oscar Salvador
2025-06-25 10:13 ` David Hildenbrand
2025-06-20 12:30 ` [PATCH v2 2/5] mm,hugetlb: Sort out folio locking in the faulting path Oscar Salvador
2025-06-23 14:11 ` David Hildenbrand
2025-06-25 7:47 ` Oscar Salvador
2025-06-25 20:47 ` Oscar Salvador
2025-06-20 12:30 ` [PATCH v2 3/5] mm,hugetlb: Rename anon_rmap to new_anon_folio and make it boolean Oscar Salvador
2025-06-20 14:28 ` Oscar Salvador
2025-06-23 14:13 ` David Hildenbrand
2025-06-25 7:43 ` Oscar Salvador [this message]
2025-06-20 12:30 ` [PATCH v2 4/5] mm,hugetlb: Drop obsolete comment about non-present pte and second faults Oscar Salvador
2025-06-20 12:30 ` [PATCH v2 5/5] mm,hugetlb: Drop unlikelys from hugetlb_fault Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFuomf97EUK2YJDJ@localhost.localdomain \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=gavinguo@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.