From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Wolfram Sang <wsa@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <brgl@bgdev.pl>,
Andi Shyti <andi.shyti@kernel.org>
Subject: Re: [PULL REQUEST] i2c-for-6.16-rc3
Date: Wed, 25 Jun 2025 11:25:41 +0200 [thread overview]
Message-ID: <aFvAlSQICukBzt7K@shikoro> (raw)
In-Reply-To: <CAHk-=wjCznJeOUSHcR5BszEUVv5BW6heO6jMX38MHXNaL3kbmQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
Linus,
> If you do conversions after the merge window, make them DAMN OBVIOUS.
> Make them minimal, make them automated, and DO NOT DO OTHER RANDOM
> CRAP AROUND THEM.
Okay, I don't want to do annoying things, so let me rephrase what I got
out of this. I should have 2 cleanup patches, one for the callback
changes and one for the whitespace changes?
Because I think the whitespace patch is needed. This is still the
beginning of a larger refactoring and having struct members initialized
according to coding style will greatly simplify next steps. And this
paragraph should then be the commit message of the whitespace patch.
I assumed that it was obvious that everything in this pull request was
automated. I honestly really don't enjoy pushing whitespaces around
manually.
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-06-25 9:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-22 13:20 [PULL REQUEST] i2c-for-6.16-rc3 Wolfram Sang
2025-06-22 18:00 ` Linus Torvalds
2025-06-25 9:25 ` Wolfram Sang [this message]
2025-06-25 15:52 ` Linus Torvalds
2025-06-22 19:55 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFvAlSQICukBzt7K@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=brgl@bgdev.pl \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.