From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Limonciello, Mario" <Mario.Limonciello@amd.com>
Cc: Mario Limonciello <superm1@kernel.org>,
Hans de Goede <hansg@kernel.org>,
Mika Westerberg <westeri@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"open list:GPIO ACPI SUPPORT" <linux-gpio@vger.kernel.org>,
"open list:GPIO ACPI SUPPORT" <linux-acpi@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:INPUT (KEYBOARD, MOUSE, JOYSTICK,
TOUCHSCREEN)..." <linux-input@vger.kernel.org>
Subject: Re: [PATCH 2/2] Revert "Input: soc_button_array - debounce the buttons"
Date: Wed, 25 Jun 2025 21:03:42 +0300 [thread overview]
Message-ID: <aFw5_rnz2dPdQcNG@smile.fi.intel.com> (raw)
In-Reply-To: <eb0a872e-0c96-43be-a583-49d221db661d@amd.com>
On Wed, Jun 25, 2025 at 05:59:50PM +0000, Limonciello, Mario wrote:
> On 6/25/25 12:54 PM, Andy Shevchenko wrote:
> > On Wed, Jun 25, 2025 at 03:34:55PM +0000, Limonciello, Mario wrote:
> >> On 6/25/25 10:17 AM, Andy Shevchenko wrote:
...
> > Probably gpiod_set_debounce() should become a no-op in this case?
>
> But my point is this 50 needs to be a quirk /somewhere/. It shouldn't
> be a default behavior.
>
> It can be in the GPIO driver(s), it can be in soc-button-array, or it
> can be in gpio_keys.
>
> I've got an idea mocked up for a v2, I'll send that out and I think we
> can discuss the merits of it on that series.
Sure, thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-25 18:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 20:22 [PATCH 0/2] Fix soc-button-array debounce Mario Limonciello
2025-06-24 20:22 ` [PATCH 1/2] gpiolib: acpi: Program debounce when finding GPIO Mario Limonciello
2025-06-25 9:02 ` Hans de Goede
2025-06-25 12:19 ` Andy Shevchenko
2025-06-24 20:22 ` [PATCH 2/2] Revert "Input: soc_button_array - debounce the buttons" Mario Limonciello
2025-06-25 9:09 ` Hans de Goede
2025-06-25 14:09 ` Mario Limonciello
2025-06-25 14:31 ` Hans de Goede
2025-06-25 14:41 ` Mario Limonciello
2025-06-25 15:02 ` Limonciello, Mario
2025-06-25 15:10 ` Andy Shevchenko
2025-06-25 15:14 ` Limonciello, Mario
2025-06-25 15:17 ` Andy Shevchenko
2025-06-25 15:34 ` Limonciello, Mario
2025-06-25 17:54 ` Andy Shevchenko
2025-06-25 17:59 ` Limonciello, Mario
2025-06-25 18:03 ` Andy Shevchenko [this message]
2025-06-25 18:57 ` Hans de Goede
2025-06-25 19:10 ` Mario Limonciello
2025-06-25 19:32 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFw5_rnz2dPdQcNG@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Mario.Limonciello@amd.com \
--cc=brgl@bgdev.pl \
--cc=dmitry.torokhov@gmail.com \
--cc=hansg@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=superm1@kernel.org \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.