From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bmailout3.hostsharing.net (bmailout3.hostsharing.net [176.9.242.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6A8A25F998 for ; Wed, 25 Jun 2025 14:33:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=176.9.242.62 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750862016; cv=none; b=NlLb4xc/Wbq2qFVkcDhPr5guXuXnyuh5DSLi+EOs2etzd/92wAe1OY7T+Rv4k8Ys2+yBFHAk2E3AN5KZk8eWvSUiw0wFqOCvNgPsinfQZ7pnVJbpyO8l/QeJux7Y1yj/IiKsZzddq1mF+R9uMXgv1/SncUmA5H7SMJ1Ej/2d47o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750862016; c=relaxed/simple; bh=/iLj6/oPmFHXVXdglfTrWoLI8TAW+tGOKSkB0IDapSA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iJcWhTfhi/cw0oSYFRnhMEE3HjxfpnkNdnibP4l7u+ADgGgmhMAG8I1ipEx50guAcFJS+lEIbZsyHddfn7P/WMFZtZsIpIgI3n/5XavOykn+opp0aEH0memMX6JMF1hGk0F29cxMJG1BtTe3J8HRXdRTSDR/FvVVNU1ZyZBHFGc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de; spf=none smtp.mailfrom=h08.hostsharing.net; arc=none smtp.client-ip=176.9.242.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=h08.hostsharing.net Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by bmailout3.hostsharing.net (Postfix) with ESMTPS id 18D2B2C000A8; Wed, 25 Jun 2025 16:33:32 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id DD5D43B7098; Wed, 25 Jun 2025 16:33:31 +0200 (CEST) Date: Wed, 25 Jun 2025 16:33:31 +0200 From: Lukas Wunner To: Hans de Goede Cc: Ben Hutchings , David Airlie , Bjorn Helgaas , Joerg Roedel , Suravee Suthikulpanit , Andi Kleen , Ahmed Salem , Borislav Petkov , dri-devel@lists.freedesktop.org, iommu@lists.linux.dev, linux-pci@vger.kernel.org Subject: Re: [PATCH] agp/amd64: Bind to unsupported devices only if AGP is present Message-ID: References: <279f63810875f2168c591aab0f30f8284d12fe02.camel@decadent.org.uk> <9077aab5304e1839786df9adb33c334d10c69397.camel@decadent.org.uk> <98012c55-1e0d-4c1b-b650-5bb189d78009@redhat.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <98012c55-1e0d-4c1b-b650-5bb189d78009@redhat.com> On Wed, Jun 25, 2025 at 04:08:38PM +0200, Hans de Goede wrote: > Lukas made me aware of this attempt to fix the KERN_CRIT msg, because > I wrote a slightly different patch to fix this: > > https://lore.kernel.org/dri-devel/20250625112411.4123-1-hansg@kernel.org/ > > This seems like a cleaner fix to me and something which would be good > to have regardless since currently the driver_attach() call is doing > too much work because the promisc table catches an unnecessary wide > net / match matching many PCI devices which cannot be AGP capable > at all. So how do you know that all of these unsupported devices have PCI_CLASS_BRIDGE_HOST? The only thing we know is that an AGP Capability must be present. In particular, AGP 3.0 sec 2.5 explicitly allows PCI-to-PCI bridges in addition to Host-to-PCI bridges. Thanks, Lukas