Re: [PATCH 083/103] ALSA: Use safer strscpy() instead of strcpy()

[Geraldo Nascimento <geraldogabriel@gmail.com>]

On Thu, Jul 10, 2025 at 12:07:05PM +0200, Takashi Iwai wrote:
> Use a safer function strscpy() instead of strcpy() for copying to
> arrays.
> 
> Only idiomatic code replacement, and no functional changes.
> 
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>  sound/pci/sis7019.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/pci/sis7019.c b/sound/pci/sis7019.c

Hi Takashi,

I think you've missed the "sis7019: " after "ALSA: " on the subject line
for this one.

Regards,
Geraldo Nascimento

> index 42b22f123fa7..3d7abcb31679 100644
> --- a/sound/pci/sis7019.c
> +++ b/sound/pci/sis7019.c
> @@ -868,7 +868,7 @@ static int sis_pcm_create(struct sis7019 *sis)
>  		return rc;
>  
>  	pcm->private_data = sis;
> -	strcpy(pcm->name, "SiS7019");
> +	strscpy(pcm->name, "SiS7019");
>  	sis->pcm = pcm;
>  
>  	snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &sis_playback_ops);
> @@ -1348,8 +1348,8 @@ static int __snd_sis7019_probe(struct pci_dev *pci,
>  	if (rc < 0)
>  		return rc;
>  
> -	strcpy(card->driver, "SiS7019");
> -	strcpy(card->shortname, "SiS7019");
> +	strscpy(card->driver, "SiS7019");
> +	strscpy(card->shortname, "SiS7019");
>  	rc = sis_chip_create(card, pci);
>  	if (rc)
>  		return rc;
> -- 
> 2.50.0
> 
>