Re: [PATCH v4 1/3] Makefile: Add size check for u-boot-with-spl.bin

[Philip Oberfichtner <pro@denx.de>]

Hi Ilias,

Thanks for having a look at this!

On Tue, Jul 08, 2025 at 02:31:37PM +0300, Ilias Apalodimas wrote:
> > diff --git a/Makefile b/Makefile
> > index fa9ce756083..791c00713ec 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1545,6 +1545,7 @@ OBJCOPYFLAGS_u-boot-with-spl.bin = -I binary -O binary \
> >                                    --pad-to=$(CONFIG_SPL_PAD_TO)
> >  u-boot-with-spl.bin: $(SPL_IMAGE) $(SPL_PAYLOAD) FORCE
> >         $(call if_changed,pad_cat)
> > +       $(SPL_SIZE_CHECK)
> 
> There's a rule in the Makefile
> ifneq ($(CONFIG_SPL_SIZE_LIMIT),0x0)
> SPL_SIZE_CHECK = @$(call size_check,$@,$$(tools/spl_size_limit))
> else
> SPL_SIZE_CHECK =
> endif
> 
> and
> 
> isn't this running?


Well, before this patch it only ran for the u-boot-spl.bin target. But I
also need it for the combined u-boot-with-spl.bin image.

I'm not sure if this answers your question?


Just for reference I'll put a link to the previous discussion with Tom:
https://patchwork.ozlabs.org/project/uboot/patch/20250527121049.106825-2-pro@denx.de/


Best regards,
Philip

> 
> Thanks
> /Ilias
>