From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Linus Walleij <linus.walleij@linaro.org>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
Srinivas Neeli <srinivas.neeli@amd.com>,
Michal Simek <michal.simek@amd.com>,
Nandor Han <nandor.han@ge.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com,
linux-arm-kernel@lists.infradead.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH 04/19] gpio: wcove: use new GPIO line value setter callbacks
Date: Wed, 9 Jul 2025 11:41:57 +0300 [thread overview]
Message-ID: <aG4rVW5m6HSnSJnv@smile.fi.intel.com> (raw)
In-Reply-To: <CAHp75VckSCyDiAtP+q8nGGiJBuMFi3Nke7Puh0SE9nBX4vUX+w@mail.gmail.com>
On Wed, Jul 09, 2025 at 11:32:40AM +0300, Andy Shevchenko wrote:
> On Wed, Jul 9, 2025 at 9:42 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
...
> > if (value)
> > - regmap_set_bits(wg->regmap, reg, 1);
> > - else
> > - regmap_clear_bits(wg->regmap, reg, 1);
> > + return regmap_set_bits(wg->regmap, reg, 1);
> > +
> > + return regmap_clear_bits(wg->regmap, reg, 1);
>
> return regmap_assign_bits(...);
Btw, since you are doing sometimes two patches, it might worth to have
a prerequisite that changes set/clear to assign and then your patch will
be cleaner.
> Otherwise LGTM,
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-07-09 10:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 6:41 [PATCH 00/19] gpio: use new GPIO line value setter callbacks in remaining drivers Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 01/19] gpio: vx855: use new GPIO line value setter callbacks Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 02/19] gpio: wcd934x: check the return value of regmap_update_bits() Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 03/19] gpio: wcd934x: use new GPIO line value setter callbacks Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 04/19] gpio: wcove: " Bartosz Golaszewski
2025-07-09 8:32 ` Andy Shevchenko
2025-07-09 8:41 ` Andy Shevchenko [this message]
2025-07-09 14:21 ` Sathyanarayanan Kuppuswamy
2025-07-09 6:41 ` [PATCH 05/19] gpio: winbond: " Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 06/19] gpio: wm831x: " Bartosz Golaszewski
2025-07-09 9:41 ` Charles Keepax
2025-07-09 6:41 ` [PATCH 07/19] gpio: wm8350: " Bartosz Golaszewski
2025-07-09 9:42 ` Charles Keepax
2025-07-09 6:41 ` [PATCH 08/19] gpio: wm8994: " Bartosz Golaszewski
2025-07-09 9:43 ` Charles Keepax
2025-07-09 6:41 ` [PATCH 09/19] gpio: xgene: " Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 10/19] gpio: xilinx: " Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 11/19] gpio: xlp: drop unneeded ngpio checks Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 12/19] gpio: xlp: use new GPIO line value setter callbacks Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 13/19] gpio: xra1403: " Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 14/19] gpio: xtensa: remove unneeded .set() callback Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 15/19] gpio: xtensa: use new GPIO line value setter callbacks Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 16/19] gpio: zevio: " Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 17/19] gpio: zynq: " Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 18/19] gpio: zynqmp-modepin: " Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 19/19] gpio: zynqmp-modepin: set line value in .direction_output() Bartosz Golaszewski
2025-07-15 7:56 ` (subset) [PATCH 00/19] gpio: use new GPIO line value setter callbacks in remaining drivers Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aG4rVW5m6HSnSJnv@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=nandor.han@ge.com \
--cc=patches@opensource.cirrus.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=shubhrajyoti.datta@amd.com \
--cc=srinivas.neeli@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.