From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB57CC83F03 for ; Wed, 9 Jul 2025 15:30:49 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1038396.1410884 (Exim 4.92) (envelope-from ) id 1uZWkl-00024D-Qh; Wed, 09 Jul 2025 15:30:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1038396.1410884; Wed, 09 Jul 2025 15:30:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uZWkl-000246-O5; Wed, 09 Jul 2025 15:30:35 +0000 Received: by outflank-mailman (input) for mailman id 1038396; Wed, 09 Jul 2025 15:30:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uZWkl-000240-9w for xen-devel@lists.xenproject.org; Wed, 09 Jul 2025 15:30:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1uZWki-008sfa-0W; Wed, 09 Jul 2025 15:30:32 +0000 Received: from [2a01:cb15:8102:5800:1e0f:9f76:7a8b:e8d1] (helo=l14) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uZWkh-00Aw6o-2o; Wed, 09 Jul 2025 15:30:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=BTBpUS1LczS677X10Rj42zmSVpqHcsU3+LLFd6g8wGM=; b=ghzBk+jTAZmvvvrDZPGYs3zxUD O0KshsQjrMJVtKe4RQ54WXYZPvGvVvNGjbUGkxopTn5I4DYr5MXecyujbAnY8RnqkmS8dOG2nMbPN Yn8XX6uoDyesrZGjNWQu6usOCnl7GQM5o1BMqor8GBCR0822Epz3/hamccHcloaILci0=; Date: Wed, 9 Jul 2025 17:30:29 +0200 From: Anthony PERARD To: Petr =?utf-8?B?QmVuZcWh?= Cc: Anthony PERARD , xen-devel@lists.xenproject.org, Nick Rosbrook , George Dunlap , Anthony PERARD , Juergen Gross Subject: Re: [PATCH v7 2/7] tools/xl: Add altp2m_count parameter Message-ID: References: <090b27895506d78055d1bab9c2b3617e85f389c6.1751397919.git.w1benny@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Jul 07, 2025 at 04:52:04PM +0200, Petr Beneš wrote: > On Mon, Jul 7, 2025 at 3:35 PM Anthony PERARD wrote: > > > > It seems that altp2m_count is going to be used for the creation of all > > guest, right? That is in addition to HVM, it will be also used for PV > > guest and on Arm, and any other architectures that could be added. > > I'm suggesting to use what is used elsewhere in the libxl_create.c: > > (https://github.com/xen-project/xen/blob/9b0f0f6e235618c2764e925b58c4bfe412730ced/tools/libs/light/libxl_create.c#L1233 > and https://github.com/xen-project/xen/blob/9b0f0f6e235618c2764e925b58c4bfe412730ced/tools/libs/light/libxl_create.c#L1241) > > ((d_config->c_info.type == LIBXL_DOMAIN_TYPE_HVM && > libxl_defbool_val(d_config->b_info.u.hvm.altp2m)) > > In other words, add check for the LIBXL_DOMAIN_TYPE_HVM type before > calling that offending libxl_defbool_val(). Would that be okay? Yes, that would be fine. > > What should be the value of altp2m_count in all this case, if altp2m is only > > set on x86 HVM guest? > > 0. Similarly to other fields that are implemented only for x86, but > are available (and technically implementable) elsewhere - like altp2m > field, vmtrace_buf_kb, etc. Ok. Thanks, -- Anthony PERARD