Re: [PATCH v1 1/2] iio: adc: ti-adc128s052: add support for adc121s021

[Sukrut Bellary <sbellary@baylibre.com>]

On Sun, Jun 29, 2025 at 06:13:54PM +0200, Lothar Rubusch wrote:
> On Sun, Jun 29, 2025 at 2:00 AM Sukrut Bellary <sbellary@baylibre.com> wrote:
> >
> > On Thu, Jun 26, 2025 at 07:28:02PM +0100, Jonathan Cameron wrote:
> > > On Thu, 26 Jun 2025 08:24:41 +0300
> > > Matti Vaittinen <mazziesaccount@gmail.com> wrote:
> > >
> > > > Hi Lothar,
> > > >
> > > > On 25/06/2025 20:02, Lothar Rubusch wrote:
> > > > > Add support for the single channel variant(s) of this ADC.
> > > > >
> > > > > Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
> > > >
> > > > Thanks for this addition. In principle, this looks good to me but I am
> > > > afraid there is another colliding series being worked on:
> > > >
> > > > https://lore.kernel.org/all/20250614091504.575685-3-sbellary@baylibre.com/
> > > >
> > > > Maybe you can align the effort with Sukrut?
> > > +CC Sukrut.
> > >
> > > >
> > > > What I specifically like (and think is the right thing to do) in
> > > > Sukrut's series is replacing the 'adc122s021_channels' -array with
> > > > individual structures. In my opinion the array is just unnecessary
> > > > complexity and individual structures are simpler.
> > > >
> > > > Other than that, this looks good to me.
> > >
> > >
> > > Sukrut, perhaps you could add this to the end of your series, rebased
> > > to those changes?  Would save a synchronization step for your v5 (and
> > > later if needed)
> > >
> > > No problem if not, but I agree with Matti that we should take your
> > > series first.
> > >
> > > Jonathan
> > >
> > Sure, I will add these adc121s0xx to the end of my v5.
> > Thanks.
> >
> 
> Hi Sukrut,
> 
> Since David Lechner still asked for ordering the TI ADC vs Rohm
> entries a bit, and complained about the missing binding entry: Shall I
> fix this rapidly and send in another version?
> 
The ordering of TI and Rohm has been addressed in my series v4 [1].
I will arrange ti,adc121xx in order in v5.

[1]. https://lore.kernel.org/all/20250614091504.575685-4-sbellary@baylibre.com/

> Best,
> L
> 
> ...