From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E92D5C83030 for ; Mon, 30 Jun 2025 12:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Wdx7EaKrJuacx8hAjq4huHf8WdXLSLaVwChw7p+wfb4=; b=TLaPqyIuFj+pj5 DWiAEyeNKrnzOkk+0rymBQujAlzU+U733885LV/8gvIJ+t2j0A/qWFzKgfg6+HaRC9ga75V/SGGfo XtlzP5dsYdJUsArh16NrymyqBwYGQTEJDk4K/YhmQmtAwNPKrpUULlVwdwWQYmyIDoUAUY4Cyx8eV 2buR6iiQEDXz9Dq02/uzB7gOSOva/PjKfu9J/UXU6/7PkmgZbJpSWFdoVQDRqHd+SqHg6rtXIHKfd L73EhZGidVe4pJO1rsgouBQFYEAafbl9o19l6sL5545fCeuj14g0G7m+1om6bGdQFQO+OM/cbLfVf AYj8CaTnyap5tpnUHubg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWDkQ-00000002CTk-26ic; Mon, 30 Jun 2025 12:36:34 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWDN5-0000000296X-2vJ4; Mon, 30 Jun 2025 12:12:28 +0000 Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-312e747d2d8so4310760a91.0; Mon, 30 Jun 2025 05:12:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751285547; x=1751890347; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9kYgTWxigFnMh6J+7o3rXH2dHsX5hLP6u8Al9k3eKS4=; b=X1QQPHmOEsEjPhMxrt+x4iBkyiCr3RUokqSVW7Vys0eIfx0iOd95IEatAwf8TPni1R MfozOmUqPhwPLo7PuMWvMiQejFmCFrAlcYrq+DOX7FABmQZ5SS0qs0MiTcC+27myyYJI m8ZRnQxJNsosxE4a3SZTSx0Obwu4TJG1ojF9rEGbxblPjEPSScXTKAB4LiIoLBXUSskY X8kWikvgleCwQDd4fK6Hww8ryCY+7bhJdrKrocD4uM5vicDpSTUEA8XuDbDc7u4iBUIn 8o3CdUOXsV7qNu2TdwWYHDYv5JJx7Z9eQte7sCRyHBu+/dBVPqb93Jp2tTzJxRdVS4ox E1Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751285547; x=1751890347; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9kYgTWxigFnMh6J+7o3rXH2dHsX5hLP6u8Al9k3eKS4=; b=eSrLjrLUlOWemrtwA4OPo80J3RS+HitW/d8EaVzFUemFjgRuVkIZZwHxsCGAMJwuS8 +ww3tHthEAjg4NIb4O9qVarcYOVOv/66QjLi0Cm3i1Kn7VJuXnVRBjVOhCnphmyS4Wn5 rp/yhfP4D2/ZfD25WS1GLSnZRA+YLySclDnV6JLjU7Hl3zeI0cPxAEzh1sC/GgzW0tyx MYpY8t6isROBRAoQTLEJMXBYNijA8r7awqNs3zJ7f8wk9Bzc5aMniNB5RoZMhkmLJ7C+ Yd3S2x15vDTRQVmTti9pA8cNhAOZd3zAo5eLY9Bbpw+H0/lBTVlbCE0LPZQZDRG7EUAn u0uQ== X-Forwarded-Encrypted: i=1; AJvYcCWWkethC+DqqoPrcg6jZC7MjfSQx1e1R0rtjJh6zGpNWGLhujevhH/d5G4zgJhcPlR/NdBq1z2P57df5ho=@lists.infradead.org, AJvYcCXATgdamlZ5rM2ZIyTeWgMpWlm1oFmwJjTlAGWA+oyY2C8TeKgMZ9e70o6/NzV95m1AS1PMMNYQAIQ=@lists.infradead.org X-Gm-Message-State: AOJu0YzgmK9dchz9Hg7S6cjUNRyP2xB4DNP0g8GEDUqqPPVXd2YrI1IU De2dZE+dgk21PvTNGQTLriEJB8s6PZwnxVSoRAjqgQtEdI6IVKR/dAmn X-Gm-Gg: ASbGnctLx2fO466Ut+4F9XbRohIE5Pvf4N40CgynNhxetpSwQBMhc8ncaA1akvqM2HF 9Z9CDCzpA2iGTF9DNSLnzf9Jc0PEBicJmRFUteRobrraN1FoL3ESU+iDZlTrBxdJT5IaKK5ZfWt 3UgGcWxs/CR8b17S4+MRKaiNbtqxNqnisyWwkV9Dqa5FcTk90DvQsgKecTZ5mTL//45c6LJoyVA 6m1+FIf4EFiH9ho7yJic9AaA8cmr7W5z4dsR3uWIkvlOY7VViXZK352PdkSf/+thYqOkLBVHgsX lHfkqNdfNHiIy17FPOIo5zKZvBOHHOpo/heNH8lz/UM48d807nc= X-Google-Smtp-Source: AGHT+IHsIFpQ45mX5GXGIU8w06ZUsQgrAuvEXHa4TYUkn6AoK+LxDTuZVhduM++WcW9fKEEMhIst4g== X-Received: by 2002:a17:90b:55d0:b0:311:482a:f956 with SMTP id 98e67ed59e1d1-316d69bf0cbmr24097074a91.5.1751285546499; Mon, 30 Jun 2025 05:12:26 -0700 (PDT) Received: from localhost ([2001:250:5800:1002::cd55]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-315f54412c6sm13168373a91.43.2025.06.30.05.12.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 05:12:25 -0700 (PDT) Date: Mon, 30 Jun 2025 20:12:22 +0800 From: Zixian Zeng To: Krzysztof Kozlowski Cc: Tudor Ambarus , Pratyush Yadav , Michael Walle , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Chen Wang , Inochi Amaoto , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Longbin Li , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v3 1/4] spi: dt-bindings: spi-sg2044-nor: Change SOPHGO SG2042 Message-ID: References: <20250629-sfg-spifmc-v3-0-28db1f27e999@gmail.com> <20250629-sfg-spifmc-v3-1-28db1f27e999@gmail.com> <20250630-ancient-quail-of-joy-effd60@krzk-bin> <4afcef9e-db98-4679-b9c1-40ffcf4861c6@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4afcef9e-db98-4679-b9c1-40ffcf4861c6@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250630_051227_737420_F80A62C3 X-CRM114-Status: GOOD ( 19.55 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Mon, Jun 30, 2025 at 01:55:58PM +0200, Krzysztof Kozlowski wrote: > On 30/06/2025 13:47, Zixian Zeng wrote: > > On Mon, Jun 30, 2025 at 09:17:09AM +0200, Krzysztof Kozlowski wrote: > >> On Sun, Jun 29, 2025 at 04:23:10PM +0800, Zixian Zeng wrote: > >>> SG2042 is not fully compatiable with SG2044, > >> > >> Typo, run spellcheck. > >> > > Thanks for spotting that! I will add spellcheck to my patch checking script next. > > > >>> So it is necessary to become independent const > >> > >> No capital letters after ,. > >> > > Ok, thanks > > > >> Anyway, explain why it is not fully compatible. > >> > > I have asked the technical staff of SOPHGO, > > the SG2044 and SG2042 are indeed incompatible with each other in some places > > because of the hardware details, regarding the configuration of the OPT register > > and FFTrgLvl(fifo trigger level) bit setting. > > So when driver binds with sg2044, the device does not work? Or what > exactly does not work? > > All this is supposed to be explained in the commit msg. > I got it, I think I had explained this in the driver patch[3/4]. If this reason is acceptable, I would like to ask whether the explanation should be put in the binding patch commit msg [1/4] instead of the driver patch commit msg [3/4]? or both? Thank you. > Best regards, > Krzysztof Best regards, Zixian ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F376C8302F for ; Mon, 30 Jun 2025 12:36:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=koGyv1Hc2k7iJ3DiQp2opXdjkp2OP0JGRCif4Qm+aOU=; b=Cj9gPUuiwJ+Eo2 t/LldA2mVZaKb+yXZIznsRhvOBD9RPGCVpgR2f9rd6Sy0+5uzeKLYu7odPSynfq6Vx/yRMs4Uvon8 s+JmxOZz8FL4PHx8HOPTtUaNtlW34BY06ad5QOIINUrfwn+aPRWQUlAj66l0BGDi5TV7QWtg4u75J NmLlnbtYZFWB+wJiVncuobObOEtFCu0FnAJsIAFeG9ubfdmWdZG7XcYbC3V5+BxaiH/Blp0Le+Sni OpIJQmXDCLRojvcUdpx5+ZxGH/dTs5iZiH2eCe8K4q3mxtTumeHeoVuzjE04pk2ztrH9o6pqaOVCR R8wggWF1XsQ2m/NRH2Pw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWDkR-00000002CUU-0u7M; Mon, 30 Jun 2025 12:36:35 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWDN5-0000000296X-2vJ4; Mon, 30 Jun 2025 12:12:28 +0000 Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-312e747d2d8so4310760a91.0; Mon, 30 Jun 2025 05:12:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751285547; x=1751890347; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9kYgTWxigFnMh6J+7o3rXH2dHsX5hLP6u8Al9k3eKS4=; b=X1QQPHmOEsEjPhMxrt+x4iBkyiCr3RUokqSVW7Vys0eIfx0iOd95IEatAwf8TPni1R MfozOmUqPhwPLo7PuMWvMiQejFmCFrAlcYrq+DOX7FABmQZ5SS0qs0MiTcC+27myyYJI m8ZRnQxJNsosxE4a3SZTSx0Obwu4TJG1ojF9rEGbxblPjEPSScXTKAB4LiIoLBXUSskY X8kWikvgleCwQDd4fK6Hww8ryCY+7bhJdrKrocD4uM5vicDpSTUEA8XuDbDc7u4iBUIn 8o3CdUOXsV7qNu2TdwWYHDYv5JJx7Z9eQte7sCRyHBu+/dBVPqb93Jp2tTzJxRdVS4ox E1Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751285547; x=1751890347; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9kYgTWxigFnMh6J+7o3rXH2dHsX5hLP6u8Al9k3eKS4=; b=eSrLjrLUlOWemrtwA4OPo80J3RS+HitW/d8EaVzFUemFjgRuVkIZZwHxsCGAMJwuS8 +ww3tHthEAjg4NIb4O9qVarcYOVOv/66QjLi0Cm3i1Kn7VJuXnVRBjVOhCnphmyS4Wn5 rp/yhfP4D2/ZfD25WS1GLSnZRA+YLySclDnV6JLjU7Hl3zeI0cPxAEzh1sC/GgzW0tyx MYpY8t6isROBRAoQTLEJMXBYNijA8r7awqNs3zJ7f8wk9Bzc5aMniNB5RoZMhkmLJ7C+ Yd3S2x15vDTRQVmTti9pA8cNhAOZd3zAo5eLY9Bbpw+H0/lBTVlbCE0LPZQZDRG7EUAn u0uQ== X-Forwarded-Encrypted: i=1; AJvYcCWWkethC+DqqoPrcg6jZC7MjfSQx1e1R0rtjJh6zGpNWGLhujevhH/d5G4zgJhcPlR/NdBq1z2P57df5ho=@lists.infradead.org, AJvYcCXATgdamlZ5rM2ZIyTeWgMpWlm1oFmwJjTlAGWA+oyY2C8TeKgMZ9e70o6/NzV95m1AS1PMMNYQAIQ=@lists.infradead.org X-Gm-Message-State: AOJu0YzgmK9dchz9Hg7S6cjUNRyP2xB4DNP0g8GEDUqqPPVXd2YrI1IU De2dZE+dgk21PvTNGQTLriEJB8s6PZwnxVSoRAjqgQtEdI6IVKR/dAmn X-Gm-Gg: ASbGnctLx2fO466Ut+4F9XbRohIE5Pvf4N40CgynNhxetpSwQBMhc8ncaA1akvqM2HF 9Z9CDCzpA2iGTF9DNSLnzf9Jc0PEBicJmRFUteRobrraN1FoL3ESU+iDZlTrBxdJT5IaKK5ZfWt 3UgGcWxs/CR8b17S4+MRKaiNbtqxNqnisyWwkV9Dqa5FcTk90DvQsgKecTZ5mTL//45c6LJoyVA 6m1+FIf4EFiH9ho7yJic9AaA8cmr7W5z4dsR3uWIkvlOY7VViXZK352PdkSf/+thYqOkLBVHgsX lHfkqNdfNHiIy17FPOIo5zKZvBOHHOpo/heNH8lz/UM48d807nc= X-Google-Smtp-Source: AGHT+IHsIFpQ45mX5GXGIU8w06ZUsQgrAuvEXHa4TYUkn6AoK+LxDTuZVhduM++WcW9fKEEMhIst4g== X-Received: by 2002:a17:90b:55d0:b0:311:482a:f956 with SMTP id 98e67ed59e1d1-316d69bf0cbmr24097074a91.5.1751285546499; Mon, 30 Jun 2025 05:12:26 -0700 (PDT) Received: from localhost ([2001:250:5800:1002::cd55]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-315f54412c6sm13168373a91.43.2025.06.30.05.12.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 05:12:25 -0700 (PDT) Date: Mon, 30 Jun 2025 20:12:22 +0800 From: Zixian Zeng To: Krzysztof Kozlowski Cc: Tudor Ambarus , Pratyush Yadav , Michael Walle , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Chen Wang , Inochi Amaoto , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Longbin Li , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v3 1/4] spi: dt-bindings: spi-sg2044-nor: Change SOPHGO SG2042 Message-ID: References: <20250629-sfg-spifmc-v3-0-28db1f27e999@gmail.com> <20250629-sfg-spifmc-v3-1-28db1f27e999@gmail.com> <20250630-ancient-quail-of-joy-effd60@krzk-bin> <4afcef9e-db98-4679-b9c1-40ffcf4861c6@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4afcef9e-db98-4679-b9c1-40ffcf4861c6@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250630_051227_737420_F80A62C3 X-CRM114-Status: GOOD ( 19.55 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Jun 30, 2025 at 01:55:58PM +0200, Krzysztof Kozlowski wrote: > On 30/06/2025 13:47, Zixian Zeng wrote: > > On Mon, Jun 30, 2025 at 09:17:09AM +0200, Krzysztof Kozlowski wrote: > >> On Sun, Jun 29, 2025 at 04:23:10PM +0800, Zixian Zeng wrote: > >>> SG2042 is not fully compatiable with SG2044, > >> > >> Typo, run spellcheck. > >> > > Thanks for spotting that! I will add spellcheck to my patch checking script next. > > > >>> So it is necessary to become independent const > >> > >> No capital letters after ,. > >> > > Ok, thanks > > > >> Anyway, explain why it is not fully compatible. > >> > > I have asked the technical staff of SOPHGO, > > the SG2044 and SG2042 are indeed incompatible with each other in some places > > because of the hardware details, regarding the configuration of the OPT register > > and FFTrgLvl(fifo trigger level) bit setting. > > So when driver binds with sg2044, the device does not work? Or what > exactly does not work? > > All this is supposed to be explained in the commit msg. > I got it, I think I had explained this in the driver patch[3/4]. If this reason is acceptable, I would like to ask whether the explanation should be put in the binding patch commit msg [1/4] instead of the driver patch commit msg [3/4]? or both? Thank you. > Best regards, > Krzysztof Best regards, Zixian _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B9CB287251; Mon, 30 Jun 2025 12:12:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751285548; cv=none; b=lOWlDc6GTcYHoGnJ7Bg9VAq98PXHJ/sU+TZTOD7SpY31gpN12zIwt3U3t+C51VjJzBRJf1RfMJd6pKG36+EHSVz4Fvzfvc8Gd1YYL33brAVi6CkCqG9KRH0D4t1Aj/ErK1x+sQnLQmdWUJowFbgG/1G2LSbxvPtfekbWcDegRnQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751285548; c=relaxed/simple; bh=ymAm2RGsauWyqhaGIKdrhj01x13vqQy3GTjiWCnEznI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TGcll/t1iHGbpiu77vYbYZww8YsalmoooENXp0wUQo4lcnmVlC2FepjN76KSzCIurXmn1e4UgT8NieyolkEQlFxNJ41Hc/YYc6yE9RiWWyBQivCNI9DBbHE2T4bVRUU+kN7796O2NdTM+02pDzliE6G8fgNcGLGHwICjEpqLYkU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=B7B8gy6C; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B7B8gy6C" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-b31e076f714so5044974a12.0; Mon, 30 Jun 2025 05:12:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751285547; x=1751890347; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9kYgTWxigFnMh6J+7o3rXH2dHsX5hLP6u8Al9k3eKS4=; b=B7B8gy6CqaZryVm5kzfiTAxCrTHwctQFEwzXrSaPOWP/4lTNuhuZN+y0M/k4Pt0bWZ liS8OFfihJfm226Qb3LkQzEd0T4NqbKiXQL0mlz9uPHTX81oxb8YPI/ilVlSlh+vjmtR UWwCAyLcRP0MESXYsau3lwacR2gORp1LY22Q0nPR1jn9GZJi68VwGeLU7TpL5QE9D2vB ZWCin1BJBQ0mDXrOlonM4Jd7u76qUO4H3uY857Kt8/oQiuonBr6DuX4Tr5WIxJ7EvFZd qO4g7tH3eXozztOVY4Y31mNP+6LrhbT64nPUPGIS+A5OaaS3S9Doq/3Tuj0CRS0XvPDC 9qYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751285547; x=1751890347; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9kYgTWxigFnMh6J+7o3rXH2dHsX5hLP6u8Al9k3eKS4=; b=SNkWSrULNV/XepQQ1HmfaAqKNak2fVNEGOqihms6jLl5ws0vr29N2+LaRrdTjKouqr tGH6wO3dgISBMy9pi0Z+xJUGVbAcGjKgU857uojLijn+mZA8JiB0evO6aMswcJNsGHZe o++ADZCEhGQej4t1JXld6Zd+lAEzM+Tw2TpldqTmtX6MQUBUBEkCy7P77fUxlYtnTVSd HB9vviTxZ6x7H6qL20cKj5ey3BUsTYJghIOMBQ1yucw3oimShU15jfzPdhDrFnquElky h0888e3klwazBUJPpGugJO5EhCw/TdGhg6wcfkqXgR6zKR07bKY0Lj9kgJsPkd8YfRN8 yYQg== X-Forwarded-Encrypted: i=1; AJvYcCWH/yvFUttYAKBdg3ziGcqINVatHW+yO9B6L2W0DOMvueNIb4TFtva1t1ti+mx7NVcreIzEIfXzIXWdZN/z@vger.kernel.org, AJvYcCWcr32YEa0MC0XPgD2agEJ5oiHl+3XdMNy5k77eGuM2gPLhUbXusix7Ym6OWKZqn0BexT+3e8ITn3ot@vger.kernel.org, AJvYcCXzIPen8ejNaTHddwcn1HitGnNY6mDGRQIIxgGX5OcI2G0MB62HtN/JVVufZryIez+cvi5sA/EpeOoq@vger.kernel.org X-Gm-Message-State: AOJu0YwV8wpSJu8tJE59wn/x8aAwGM/DzvTJEoHkU//Ui3zDi/w8OjVz 3Pax2CsGzm8PWsTXN0cKDHGdDh7ldezWyz/YVMBsqx0cY9WvEBH8lGcj X-Gm-Gg: ASbGncsx9IEzqawCvQRZ/P9HZVfoIYKRqrfQRuLCU3Twyylq0BsKKguYS/m4NIIIYWH 8SpK9PuuYlArBvjEyezBV3VxmzNc4ejSGrn1uGOEhvO2H8OdvOlsc7Os/js9ljo3KLBLmctGK00 4Xd2zGgtKo6B/qbdPZbHiwwVzV992fPytWFW8efErYvFhba8el6Swr4hfKFA1DQ7K20Pm7l7opy HyX2L4qoF8pbIHTEbkK/mffmmqzUov/uCaeYD/qTzfNFg8grNiqPPBprGNf1zIxsSjJ/xNkZPHg a7T6AMxD58z+lcjJ1Wv0gPo5HIFQQYHJNKa0IR8DviDm0eqPrwg= X-Google-Smtp-Source: AGHT+IHsIFpQ45mX5GXGIU8w06ZUsQgrAuvEXHa4TYUkn6AoK+LxDTuZVhduM++WcW9fKEEMhIst4g== X-Received: by 2002:a17:90b:55d0:b0:311:482a:f956 with SMTP id 98e67ed59e1d1-316d69bf0cbmr24097074a91.5.1751285546499; Mon, 30 Jun 2025 05:12:26 -0700 (PDT) Received: from localhost ([2001:250:5800:1002::cd55]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-315f54412c6sm13168373a91.43.2025.06.30.05.12.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 05:12:25 -0700 (PDT) Date: Mon, 30 Jun 2025 20:12:22 +0800 From: Zixian Zeng To: Krzysztof Kozlowski Cc: Tudor Ambarus , Pratyush Yadav , Michael Walle , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Chen Wang , Inochi Amaoto , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Longbin Li , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v3 1/4] spi: dt-bindings: spi-sg2044-nor: Change SOPHGO SG2042 Message-ID: References: <20250629-sfg-spifmc-v3-0-28db1f27e999@gmail.com> <20250629-sfg-spifmc-v3-1-28db1f27e999@gmail.com> <20250630-ancient-quail-of-joy-effd60@krzk-bin> <4afcef9e-db98-4679-b9c1-40ffcf4861c6@kernel.org> Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4afcef9e-db98-4679-b9c1-40ffcf4861c6@kernel.org> On Mon, Jun 30, 2025 at 01:55:58PM +0200, Krzysztof Kozlowski wrote: > On 30/06/2025 13:47, Zixian Zeng wrote: > > On Mon, Jun 30, 2025 at 09:17:09AM +0200, Krzysztof Kozlowski wrote: > >> On Sun, Jun 29, 2025 at 04:23:10PM +0800, Zixian Zeng wrote: > >>> SG2042 is not fully compatiable with SG2044, > >> > >> Typo, run spellcheck. > >> > > Thanks for spotting that! I will add spellcheck to my patch checking script next. > > > >>> So it is necessary to become independent const > >> > >> No capital letters after ,. > >> > > Ok, thanks > > > >> Anyway, explain why it is not fully compatible. > >> > > I have asked the technical staff of SOPHGO, > > the SG2044 and SG2042 are indeed incompatible with each other in some places > > because of the hardware details, regarding the configuration of the OPT register > > and FFTrgLvl(fifo trigger level) bit setting. > > So when driver binds with sg2044, the device does not work? Or what > exactly does not work? > > All this is supposed to be explained in the commit msg. > I got it, I think I had explained this in the driver patch[3/4]. If this reason is acceptable, I would like to ask whether the explanation should be put in the binding patch commit msg [1/4] instead of the driver patch commit msg [3/4]? or both? Thank you. > Best regards, > Krzysztof Best regards, Zixian