All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Thomas Richter <tmricht@linux.ibm.com>,
	linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
	linux-perf-users@vger.kernel.org, acme@kernel.org,
	agordeev@linux.ibm.com, gor@linux.ibm.com,
	sumanthk@linux.ibm.com, hca@linux.ibm.com, japo@linux.ibm.com
Subject: Re: [PATCH] perf test: perf header test fails on s390
Date: Mon, 30 Jun 2025 09:09:41 -0700	[thread overview]
Message-ID: <aGK2xQNQOd1WoDVk@google.com> (raw)
In-Reply-To: <CAP-5=fWGiitgromQRTxEsU3cY99gFAU6WPLnmiS7-Q8vQNGbYw@mail.gmail.com>

On Mon, Jun 30, 2025 at 08:42:01AM -0700, Ian Rogers wrote:
> On Mon, Jun 30, 2025 at 2:16 AM Thomas Richter <tmricht@linux.ibm.com> wrote:
> >
> > commit 2d584688643fa ("perf test: Add header shell test")
> > introduced a new test case for perf header. It fails on s390
> > because call graph option -g is not supported on s390.
> > Also the option --call-graph dwarf is only supported for
> > the event cpu-clock.
> >
> > Remove this option and the test succeeds.
> >
> > Output after:
> >  # ./perf test 76
> >  76: perf header tests                           : Ok
> >
> > Fixes: 2d584688643fa ("perf test: Add header shell test")
> > Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
> > Acked-by: Sumanth Korikkar <sumanthk@linux.ibm.com>
> > Cc: Ian Rogers <irogers@google.com>
> 
> Thanks Thomas! Given the s390 restriction to require dwarf, should we
> switch the default "-g" meaning on s390 to mean use dwarf? James Clark
> proposed this previously. It doesn't affect the change here so:
> 
> Reviewed-by: Ian Rogers <irogers@google.com>

Unrelated but I found this test is failing on my machine.

  $ ./perf test -v header
  --- start ---
  test child forked, pid 42799
  Test perf header file
  [ perf record: Woken up 1 times to write data ]
  [ perf record: Captured and wrote 0.182 MB /tmp/__perf_test_header.perf.data.vvFUf (4114 samples) ]
  Test perf header file [Done]
  Test perf header pipe
  Failed to find expect hostname in output
  Failed to find expect os release in output
  Failed to find expect arch in output
  Failed to find expect cpuid in output
  Failed to find expect nrcpus in output
  Failed to find expect event in output
  Failed to find expect cmdline in output
  Failed to find expect perf version in output
  Failed to find expect sibling (cores|dies|threads) in output
  Failed to find expect sibling threads in output
  Failed to find expect total memory in output
  Test perf header pipe [Done]
  ---- end(-1) ----
   83: perf header tests                                               : FAILED!
  
The pipe mode doesn't have the headers.

  $ ./perf record -o- -g -- ./perf test -w noploop | ./perf report -i- -I --header-only
  # ========
  # captured on    : Mon Jun 30 09:02:09 2025
  # header version : 1
  # data offset    : 0
  # data size      : 0
  # feat offset    : 0
  # ========
  #

Thanks,
Namhyung


  reply	other threads:[~2025-06-30 16:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-30  9:16 [PATCH] perf test: perf header test fails on s390 Thomas Richter
2025-06-30 15:42 ` Ian Rogers
2025-06-30 16:09   ` Namhyung Kim [this message]
2025-06-30 16:38     ` Ian Rogers
2025-07-01 17:55 ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aGK2xQNQOd1WoDVk@google.com \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=irogers@google.com \
    --cc=japo@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=sumanthk@linux.ibm.com \
    --cc=tmricht@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.