From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 06/10] ata: ahci: Disable DIPM if host lacks support
Date: Mon, 30 Jun 2025 16:50:00 +0200 [thread overview]
Message-ID: <aGKkGKaeOC1jxueM@ryzen> (raw)
In-Reply-To: <20250630062637.258329-7-dlemoal@kernel.org>
On Mon, Jun 30, 2025 at 03:26:33PM +0900, Damien Le Moal wrote:
> The AHCI specification version 1.3.1 section 8.3.1.4 (Software
> Requirements and Precedence) states that:
>
> If CAP.SSC or CAP.PSC is cleared to ‘0’, software should disable
> device-initiated power management by issuing the appropriate SET
> FEATURES command to the device.
>
> To satisfy this constraint and force ata_dev_configure to disable the
> device DIPM feature, modify ahci_update_initial_lpm_policy() to set the
> ATA_FLAG_NO_DIPM flag on ports that have a host with either the
> ATA_HOST_NO_PART flag set or the ATA_HOST_NO_SSC flag set.
>
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
next prev parent reply other threads:[~2025-06-30 14:50 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 6:26 [PATCH 00/10] Improve link power management Damien Le Moal
2025-06-30 6:26 ` [PATCH 01/10] ata: libata-core: Introduce ata_dev_config_lpm() Damien Le Moal
2025-06-30 14:46 ` Niklas Cassel
2025-07-01 6:09 ` Hannes Reinecke
2025-06-30 6:26 ` [PATCH 02/10] ata: libata-core: Move device LPM quirk settings to ata_dev_config_lpm() Damien Le Moal
2025-06-30 14:47 ` Niklas Cassel
2025-07-01 6:13 ` Hannes Reinecke
2025-07-01 6:43 ` Damien Le Moal
2025-07-01 7:19 ` Hannes Reinecke
2025-06-30 6:26 ` [PATCH 03/10] ata: libata-core: Advertize device support for DIPM and HIPM features Damien Le Moal
2025-06-30 14:47 ` Niklas Cassel
2025-07-01 6:14 ` Hannes Reinecke
2025-06-30 6:26 ` [PATCH 04/10] ata: libata-eh: Avoid unnecessary resets when revalidating devices Damien Le Moal
2025-06-30 14:47 ` Niklas Cassel
2025-07-01 6:23 ` Hannes Reinecke
2025-07-01 6:48 ` Damien Le Moal
2025-07-01 7:21 ` Hannes Reinecke
2025-07-01 9:24 ` Niklas Cassel
2025-07-01 9:25 ` Damien Le Moal
2025-06-30 6:26 ` [PATCH 05/10] ata: libata-sata: Disallow changing LPM state if not supported Damien Le Moal
2025-06-30 14:49 ` Niklas Cassel
2025-07-01 6:23 ` Hannes Reinecke
2025-06-30 6:26 ` [PATCH 06/10] ata: ahci: Disable DIPM if host lacks support Damien Le Moal
2025-06-30 14:50 ` Niklas Cassel [this message]
2025-07-01 6:23 ` Hannes Reinecke
2025-06-30 6:26 ` [PATCH 07/10] ata: ahci: Disallow LPM policy control for external ports Damien Le Moal
2025-06-30 14:50 ` Niklas Cassel
2025-07-01 6:24 ` Hannes Reinecke
2025-06-30 6:26 ` [PATCH 08/10] ata: ahci: Disallow LPM policy control if not supported Damien Le Moal
2025-06-30 8:30 ` Sergey Shtylyov
2025-06-30 15:07 ` Niklas Cassel
2025-07-01 6:25 ` Hannes Reinecke
2025-06-30 6:26 ` [PATCH 09/10] ata: libata-core: Reduce the number of messages signaling broken LPM Damien Le Moal
2025-06-30 15:08 ` Niklas Cassel
2025-07-01 6:26 ` Hannes Reinecke
2025-06-30 6:26 ` [PATCH 10/10] ata: libata_eh: Add debug messages to ata_eh_link_set_lpm() Damien Le Moal
2025-06-30 15:11 ` Niklas Cassel
2025-06-30 15:25 ` Sergey Shtylyov
2025-07-01 6:27 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGKkGKaeOC1jxueM@ryzen \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.