From: Johannes Thumshirn <jth@kernel.org>
To: herculoxz <abhinav.ogl@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Replace the use of scnprintf() with sysfs_emit_at() in several show functions to format the output into the sysfs buffer.
Date: Tue, 1 Jul 2025 08:46:18 +0200 [thread overview]
Message-ID: <aGOEOu7-oh1Nb9mm@nuc> (raw)
In-Reply-To: <20250629175330.5834-1-abhinav.ogl@gmail.com>
On Sun, Jun 29, 2025 at 11:23:30PM +0530, herculoxz wrote:
> This change improves clarity and ensures proper bounds checking in
> line with the preferred sysfs_emit() API usage for sysfs 'show'
> functions. The PAGE_SIZE check is now handled internally by the helper.
Can you please a) add an 'mcb:' prefix to the subject and b) make it fit into
~75 chars?
Code wise it looks ok:
Reviewed-by: Johannes Thumshirn <jth@kernel.org>
prev parent reply other threads:[~2025-07-01 6:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-29 17:53 [PATCH] Replace the use of scnprintf() with sysfs_emit_at() in several show functions to format the output into the sysfs buffer herculoxz
2025-07-01 6:46 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGOEOu7-oh1Nb9mm@nuc \
--to=jth@kernel.org \
--cc=abhinav.ogl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.