From: "Ahmed S. Darwish" <darwi@linutronix.de>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Christian Brauner <brauner@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH][RFC] fold fs_struct->{lock,seq} into a seqlock
Date: Wed, 2 Jul 2025 11:15:42 +0200 [thread overview]
Message-ID: <aGT4vvHMFxBsbSv1@lx-t490> (raw)
In-Reply-To: <20250702053437.GC1880847@ZenIV>
On Wed, 02 Jul 2025, Al Viro wrote:
>
> The combination of spinlock_t lock and seqcount_spinlock_t seq
> in struct fs_struct is an open-coded seqlock_t (see linux/seqlock_types.h).
> Combine and switch to equivalent seqlock_t primitives. AFAICS,
> that does end up with the same sequence of underlying operations in all
> cases.
> While we are at it, get_fs_pwd() is open-coded verbatim in
> get_path_from_fd(); rather than applying conversion to it, replace with
> the call of get_fs_pwd() there. Not worth splitting the commit for that,
> IMO...
>
> A bit of historical background - conversion of seqlock_t to
> use of seqcount_spinlock_t happened several months after the same
> had been done to struct fs_struct; switching fs_struct to seqlock_t
> could've been done immediately after that, but it looks like nobody
> had gotten around to that until now.
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
Acked-by: Ahmed S. Darwish <darwi@linutronix.de>
prev parent reply other threads:[~2025-07-02 9:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 5:34 [PATCH][RFC] fold fs_struct->{lock,seq} into a seqlock Al Viro
2025-07-02 8:31 ` Christian Brauner
2025-07-02 8:48 ` Peter Zijlstra
2025-07-02 9:15 ` Ahmed S. Darwish [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGT4vvHMFxBsbSv1@lx-t490 \
--to=darwi@linutronix.de \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.