All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Pedro Nariyoshi <pedro.nariyoshi@gmail.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Benson Leung <bleung@chromium.org>,
	Guenter Roeck <groeck@chromium.org>,
	linux-media@vger.kernel.org, chrome-platform@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	Mr Chromebox <mrchromebox@gmail.com>
Subject: Re: [PATCH] media: cros-ec-cec: Add Fizz board variants, so driver can detect them
Date: Wed, 2 Jul 2025 06:52:07 +0000	[thread overview]
Message-ID: <aGTXF-FQoJx3bMYB@google.com> (raw)
In-Reply-To: <20250628181530.873795-1-pedro.nariyoshi@gmail.com>

On Sat, Jun 28, 2025 at 02:14:35PM -0400, Pedro Nariyoshi wrote:
> I recently reflashed a Chromebox (Wukong variant of the Fizz board) with
> coreboot and I noticed that the cec driver refused to load with a bit of
> tinkering, I realized that the dmi_match_table was expecting the product
> name to be Fizz, but `dmidecode` reports `Wukong` as the product name. I
> am not sure if this is the best approach, but adding this patch lets me
> load the driver and it works properly.
> 
> Alternatively, we could instead match the DMI_PRODUCT_FAMILY, instead of
> DMI_SYS_VENDOR and DMI_PRODUCT_NAME. In my board at least, that says
> "Google_Fizz".

Yes, please extend the table of `struct cec_dmi_match` and support
DMI_PRODUCT_FAMILY match in cros_ec_cec_find_hdmi_dev().

> I am open to suggestions for alternative solutions and I hope I did't
> break any rules (this is my first kernel patch). (And sorry for the
> previous submissions with errors in the subject line)

Thank you for your patch. You could consider to move most of the additional
information after "---" in your patch (so that they won't be part of the
commit message).

  parent reply	other threads:[~2025-07-02  6:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-28 18:14 [PATCH] media: cros-ec-cec: Add Fizz board variants, so driver can detect them Pedro Nariyoshi
2025-06-30  6:25 ` hans
     [not found]   ` <CAHPgyW5s8HB5op9z8cMPJPJ-9=e4Ufp6R3U3jABOxXD0Rzt06g@mail.gmail.com>
2025-06-30 13:13     ` Mr. Chromebox
2025-07-02  6:52 ` Tzung-Bi Shih [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-06-26 18:03 [PATCH] media : " Pedro Nariyoshi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aGTXF-FQoJx3bMYB@google.com \
    --to=tzungbi@kernel.org \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=groeck@chromium.org \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mrchromebox@gmail.com \
    --cc=pedro.nariyoshi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.