From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/vsprintf: include stdarg.h from sprintf.h to provide va_list
Date: Wed, 2 Jul 2025 11:07:44 +0300 [thread overview]
Message-ID: <aGTo0FBpm50EhCc5@smile.fi.intel.com> (raw)
In-Reply-To: <hm3lxgfzjhxigj5no5csubdo6kolvdjwyhpveirbzptcdbmcag@tqunw2rllae4>
On Tue, Jul 01, 2025 at 09:27:24PM -0700, Dmitry Torokhov wrote:
> Declarations in sprintf.h use va_list so it needs to include stdarg.h,
> otherwise we may be getting warnings like this:
>
> ./include/linux/sprintf.h:11:54: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
> 11 | __printf(2, 0) int vsprintf(char *buf, const char *, va_list);
> | ^
> | int
Ah, thanks for a good catch!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-07-02 8:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 4:27 [PATCH] lib/vsprintf: include stdarg.h from sprintf.h to provide va_list Dmitry Torokhov
2025-07-02 8:07 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGTo0FBpm50EhCc5@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.