From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bmailout2.hostsharing.net (bmailout2.hostsharing.net [83.223.78.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50CAD1F5437 for ; Wed, 2 Jul 2025 10:47:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.223.78.240 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751453274; cv=none; b=BEXYAV/dC9ZOurYck8VpGCX0ZEX7J22p5m4SVRh01gjD7yB4S8EBP1P/SiH2+OZDplKOMFPODbrcd0XTzdwV69NACztF/yyyecvws5zE0bw9tmBQDVzyA9Fc1lpQik+IZWHEe00Ke7Mbql/nBjauTKVtY3QnAibj3hiAEpRf6dA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751453274; c=relaxed/simple; bh=mueIBmRkHOw7+zKo9vy7t8XK9F21CpXo9FP5gI3LfZI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C5vDNb5h65nzBRrPzztPYXsXgIjk6RfJOFPHFo0dWccOHM4P7/N/ZX8FVYYquRXPw5RuUDKLX8Z1K4MXWj4YH3R0b2HUOpxTys4sEHW0joHS6AsrFEjJbDP2q/n5HG1DQf8hOYm2fsFI1Dm8BjN2VaD1CXeD0lqiKPsJ4OKFF3Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de; spf=none smtp.mailfrom=h08.hostsharing.net; arc=none smtp.client-ip=83.223.78.240 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=h08.hostsharing.net Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by bmailout2.hostsharing.net (Postfix) with ESMTPS id 4DFB22006F45; Wed, 2 Jul 2025 12:47:49 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 47A3C3D6A4C; Wed, 2 Jul 2025 12:47:49 +0200 (CEST) Date: Wed, 2 Jul 2025 12:47:49 +0200 From: Lukas Wunner To: Hans de Goede Cc: Ben Hutchings , David Airlie , Bjorn Helgaas , Joerg Roedel , Suravee Suthikulpanit , Andi Kleen , Ahmed Salem , Borislav Petkov , dri-devel@lists.freedesktop.org, iommu@lists.linux.dev, linux-pci@vger.kernel.org Subject: Re: [PATCH] agp/amd64: Bind to unsupported devices only if AGP is present Message-ID: References: <279f63810875f2168c591aab0f30f8284d12fe02.camel@decadent.org.uk> <9077aab5304e1839786df9adb33c334d10c69397.camel@decadent.org.uk> <98012c55-1e0d-4c1b-b650-5bb189d78009@redhat.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jun 30, 2025 at 01:10:24PM +0200, Hans de Goede wrote: > ping? It would be good to get some consensus on how to > fix this and move forward with a fix. Either the patch from > this thread; or my patch: > > https://lore.kernel.org/dri-devel/20250625112411.4123-1-hansg@kernel.org/ > > Works for me, the most important thing here is to get this > regression fixed. You seem to have a machine where you can trigger the "Resources present before probing" message. Would you mind enabling CONFIG_DEBUG_DEVRES=y and adding "log_devres=1" to the kernel command line so that we can understand what kind of resource is attached to the AMD IOMMU, and where that happens. I don't see invocations of devm_*() in arch/x86/ or drivers/iommu/amd/ that would explain the error message. Just so that we get a full understanding of the issue, independently of the AGP driver probing everything. Thanks! Lukas