From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43BA2265CD0; Wed, 2 Jul 2025 11:39:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751456374; cv=none; b=Iu3KZUergqVp9kbPutZIxdKgjYnxnEafpgAl1gySfgk0JPQs6tG/mWY6pJNasaRrFwT8TVluUq3jZq3LlYMx8OTeUDS+BqS+dDt6Q7Z02A14jVCNx6Xp+SxXbYc5wczH6fO5utFxuA5+KwZn4VLvXvHP0FMTT7i8ZFwcUto8Lx4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751456374; c=relaxed/simple; bh=v6saksW8Caqa3y5KRNV+vSZS7ie/jhuoui51AlwXf7k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hrcIm5KSPQR+KynNgeKGYDPTcZ+XH6eZBbNjVL7TfxR9vxy9sjUsv7ndpoKz7JBvlo9+UyXq9ixycAj08NV35YbHI4nZxmwD/vkj0kLcdgww/R9+sqvsyUkFZGCoJ/Ba+zHV7a1v4wCB4Etd6Y4yPVY50ZIrIPYW4NkvksujVso= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=i12nkX6K; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="i12nkX6K" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751456372; x=1782992372; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=v6saksW8Caqa3y5KRNV+vSZS7ie/jhuoui51AlwXf7k=; b=i12nkX6KePKsTzSyCbJg7mcAKzn4I7HwVXH1Q+pX2ZLor97N2rDK1JlI 625fUfGZt5BeSReeNCoL8z3MxGb5deHdDUwtYRvJDBoBYTfrBcZIvEjtx cjxlQMPHDBTZHuEHmFPQMSh86SfcdWNRgwy5oxeens3O11QS5/OlSzYwL Aum2x7D9LPHaES6PEWKuRCtEZWx9VlpplJWlVNpCCywC6oW0llFj5ybpI pT5vfwp8RBGDkpqOQD4s05+yD/21+uJmCaHSRivHW/rD2oEcVLxlYh99H GzipJxDo9CSSe9tk60Ugt4caTj0/KiI0iDb5rYkU5F8tT45XXQs8kRVEh w==; X-CSE-ConnectionGUID: lJMvkXwYQ4O29/jIE43FXw== X-CSE-MsgGUID: AOIUzDZBSlado5EPrEXHeQ== X-IronPort-AV: E=McAfee;i="6800,10657,11481"; a="53839539" X-IronPort-AV: E=Sophos;i="6.16,281,1744095600"; d="scan'208";a="53839539" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2025 04:39:30 -0700 X-CSE-ConnectionGUID: mlpi9m3FSByAEgGF4mUwsw== X-CSE-MsgGUID: kJgdkV2/ROyIIrCgnKDzDQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,281,1744095600"; d="scan'208";a="184998772" Received: from smile.fi.intel.com ([10.237.72.52]) by fmviesa001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2025 04:39:25 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1uWvo8-0000000BuBI-3Jry; Wed, 02 Jul 2025 14:39:20 +0300 Date: Wed, 2 Jul 2025 14:39:20 +0300 From: Andy Shevchenko To: "Rafael J. Wysocki" Cc: Anup Patel , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jassi Brar , Thomas Gleixner , Mika Westerberg , Linus Walleij , Bartosz Golaszewski , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Palmer Dabbelt , Paul Walmsley , Alexandre Ghiti , Len Brown , Sunil V L , Rahul Pathak , Leyfoon Tan , Atish Patra , Andrew Jones , Samuel Holland , Anup Patel , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 15/24] ACPI: property: Add support for cells property Message-ID: References: <20250702051345.1460497-1-apatel@ventanamicro.com> <20250702051345.1460497-16-apatel@ventanamicro.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Jul 02, 2025 at 02:37:58PM +0300, Andy Shevchenko wrote: > On Wed, Jul 02, 2025 at 12:20:55PM +0200, Rafael J. Wysocki wrote: > > On Wed, Jul 2, 2025 at 7:16 AM Anup Patel wrote: ... > > > static int acpi_fwnode_get_reference_args(const struct fwnode_handle *fwnode, > > > const char *propname, const char *nargs_prop, > > > unsigned int args_count, unsigned int index, > > > > const struct acpi_device_data *data; > > > struct fwnode_handle *ref_fwnode; > > > struct acpi_device *device; > > > + unsigned int nargs_count; > > > int ret, idx = 0; > > > > + nargs_count = acpi_fwnode_get_args_count(device, nargs_prop); > > > > I think it should work the same way as it used to for the callers that > > pass args_count, so maybe > > > > if (!args_count) > > args_count = acpi_fwnode_get_args_count(device, nargs_prop); > > But this is different variable. > > > > element++; > > > - > > > ret = acpi_get_ref_args(idx == index ? args : NULL, > > > acpi_fwnode_handle(device), > > > - &element, end, args_count); > > > + &element, end, > > > + nargs_count ? nargs_count : args_count); > > > > And this change would not be necessary? > > This is not the same check as proposed above. > But this can be made shorter with Elvis in use: > > &element, end, nargs_count ?: args_count); > > > And analogously below. > > And below. And in case if there is a new proposal to have > > if (!nargs_count) I meant if (!nargs_prop) here of course. > args_count = acpi_fwnode_get_args_count(device, nargs_prop); > > that is exactly what I asked to drop as it's included in the > acpi_fwnode_get_args_count() already, i.e. no need to check this in > the caller and in the callee. > > > > if (ret < 0) > > > return ret; -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C0AAC83F05 for ; Wed, 2 Jul 2025 12:23:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UfuC7lrMhKL6xWCfMz545KUv2165hZNBP20zqpbPDkA=; b=n5+OpgN3oRtEFQ ESwaNjehyZUIkMNMmonhDTQRxk1nl7BN7eW37Wu4H4Da3E9g4/XLm/3wppBKLP1c+RsqZYNRz6JD8 mPv/bHvw0wfvNkhQyspkw7EE1j6ZIqLqIQ/6KhzNxjZBo72YcXYH42ZmTJavybFzjswUIS8CoqnTJ T5t3Qx4qeUTPcN9RvJpgjWEzf3drhsKYKhtu5q9/OWe8N76cy59yEtb4NiFNZ/lKaqKyZKQS/X1Va IhqWukfNtB+hbOOxsuRSgwlS8nd1uFSQccaJEryVIT0hwxIoiGH3WmZJmv2VgG8dZML+oC1KVRxoO D8VW6SQfyPgrCVVDN7lA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWwVC-00000008ImL-2Oj0; Wed, 02 Jul 2025 12:23:50 +0000 Received: from mgamail.intel.com ([192.198.163.14]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWvoK-00000008A3T-1gGW for linux-riscv@lists.infradead.org; Wed, 02 Jul 2025 11:39:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751456372; x=1782992372; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=v6saksW8Caqa3y5KRNV+vSZS7ie/jhuoui51AlwXf7k=; b=i12nkX6KePKsTzSyCbJg7mcAKzn4I7HwVXH1Q+pX2ZLor97N2rDK1JlI 625fUfGZt5BeSReeNCoL8z3MxGb5deHdDUwtYRvJDBoBYTfrBcZIvEjtx cjxlQMPHDBTZHuEHmFPQMSh86SfcdWNRgwy5oxeens3O11QS5/OlSzYwL Aum2x7D9LPHaES6PEWKuRCtEZWx9VlpplJWlVNpCCywC6oW0llFj5ybpI pT5vfwp8RBGDkpqOQD4s05+yD/21+uJmCaHSRivHW/rD2oEcVLxlYh99H GzipJxDo9CSSe9tk60Ugt4caTj0/KiI0iDb5rYkU5F8tT45XXQs8kRVEh w==; X-CSE-ConnectionGUID: cTrS06ECRUCjlElHCDnPrQ== X-CSE-MsgGUID: mZwh9KgRSL6fLg7DoubctQ== X-IronPort-AV: E=McAfee;i="6800,10657,11481"; a="53839540" X-IronPort-AV: E=Sophos;i="6.16,281,1744095600"; d="scan'208";a="53839540" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2025 04:39:30 -0700 X-CSE-ConnectionGUID: mlpi9m3FSByAEgGF4mUwsw== X-CSE-MsgGUID: kJgdkV2/ROyIIrCgnKDzDQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,281,1744095600"; d="scan'208";a="184998772" Received: from smile.fi.intel.com ([10.237.72.52]) by fmviesa001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2025 04:39:25 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1uWvo8-0000000BuBI-3Jry; Wed, 02 Jul 2025 14:39:20 +0300 Date: Wed, 2 Jul 2025 14:39:20 +0300 From: Andy Shevchenko To: "Rafael J. Wysocki" Subject: Re: [PATCH v7 15/24] ACPI: property: Add support for cells property Message-ID: References: <20250702051345.1460497-1-apatel@ventanamicro.com> <20250702051345.1460497-16-apatel@ventanamicro.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250702_043932_455895_2722D6BA X-CRM114-Status: GOOD ( 23.99 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Atish Patra , Michael Turquette , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org, Rob Herring , Alexandre Ghiti , Anup Patel , Bartosz Golaszewski , Jassi Brar , linux-acpi@vger.kernel.org, Linus Walleij , Andrew Jones , devicetree@vger.kernel.org, Conor Dooley , Leyfoon Tan , Paul Walmsley , Thomas Gleixner , Mika Westerberg , Anup Patel , Stephen Boyd , linux-kernel@vger.kernel.org, Samuel Holland , Palmer Dabbelt , Krzysztof Kozlowski , Rahul Pathak , Len Brown Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKdWwgMDIsIDIwMjUgYXQgMDI6Mzc6NThQTSArMDMwMCwgQW5keSBTaGV2Y2hlbmtv IHdyb3RlOgo+IE9uIFdlZCwgSnVsIDAyLCAyMDI1IGF0IDEyOjIwOjU1UE0gKzAyMDAsIFJhZmFl bCBKLiBXeXNvY2tpIHdyb3RlOgo+ID4gT24gV2VkLCBKdWwgMiwgMjAyNSBhdCA3OjE24oCvQU0g QW51cCBQYXRlbCA8YXBhdGVsQHZlbnRhbmFtaWNyby5jb20+IHdyb3RlOgoKLi4uCgo+ID4gPiAg c3RhdGljIGludCBhY3BpX2Z3bm9kZV9nZXRfcmVmZXJlbmNlX2FyZ3MoY29uc3Qgc3RydWN0IGZ3 bm9kZV9oYW5kbGUgKmZ3bm9kZSwKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgY29uc3QgY2hhciAqcHJvcG5hbWUsIGNvbnN0IGNoYXIgKm5hcmdzX3Byb3As Cj4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVk IGludCBhcmdzX2NvdW50LCB1bnNpZ25lZCBpbnQgaW5kZXgsCj4gCj4gPiA+ICAgICAgICAgY29u c3Qgc3RydWN0IGFjcGlfZGV2aWNlX2RhdGEgKmRhdGE7Cj4gPiA+ICAgICAgICAgc3RydWN0IGZ3 bm9kZV9oYW5kbGUgKnJlZl9md25vZGU7Cj4gPiA+ICAgICAgICAgc3RydWN0IGFjcGlfZGV2aWNl ICpkZXZpY2U7Cj4gPiA+ICsgICAgICAgdW5zaWduZWQgaW50IG5hcmdzX2NvdW50Owo+ID4gPiAg ICAgICAgIGludCByZXQsIGlkeCA9IDA7Cj4gCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAg IG5hcmdzX2NvdW50ID0gYWNwaV9md25vZGVfZ2V0X2FyZ3NfY291bnQoZGV2aWNlLCBuYXJnc19w cm9wKTsKPiA+IAo+ID4gSSB0aGluayBpdCBzaG91bGQgd29yayB0aGUgc2FtZSB3YXkgYXMgaXQg dXNlZCB0byBmb3IgdGhlIGNhbGxlcnMgdGhhdAo+ID4gcGFzcyBhcmdzX2NvdW50LCBzbyBtYXli ZQo+ID4gCj4gPiBpZiAoIWFyZ3NfY291bnQpCj4gPiAgICAgICAgIGFyZ3NfY291bnQgPSBhY3Bp X2Z3bm9kZV9nZXRfYXJnc19jb3VudChkZXZpY2UsIG5hcmdzX3Byb3ApOwo+IAo+IEJ1dCB0aGlz IGlzIGRpZmZlcmVudCB2YXJpYWJsZS4KPiAKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAg ZWxlbWVudCsrOwo+ID4gPiAtCj4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIHJldCA9IGFj cGlfZ2V0X3JlZl9hcmdzKGlkeCA9PSBpbmRleCA/IGFyZ3MgOiBOVUxMLAo+ID4gPiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBhY3BpX2Z3bm9kZV9oYW5k bGUoZGV2aWNlKSwKPiA+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgJmVsZW1lbnQsIGVuZCwgYXJnc19jb3VudCk7Cj4gPiA+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZlbGVtZW50LCBlbmQsCj4gPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5hcmdzX2NvdW50 ID8gbmFyZ3NfY291bnQgOiBhcmdzX2NvdW50KTsKPiA+IAo+ID4gQW5kIHRoaXMgY2hhbmdlIHdv dWxkIG5vdCBiZSBuZWNlc3Nhcnk/Cj4gCj4gVGhpcyBpcyBub3QgdGhlIHNhbWUgY2hlY2sgYXMg cHJvcG9zZWQgYWJvdmUuCj4gQnV0IHRoaXMgY2FuIGJlIG1hZGUgc2hvcnRlciB3aXRoIEVsdmlz IGluIHVzZToKPiAKPiAJCQkJCQkmZWxlbWVudCwgZW5kLCBuYXJnc19jb3VudCA/OiBhcmdzX2Nv dW50KTsKPiAKPiA+IEFuZCBhbmFsb2dvdXNseSBiZWxvdy4KPiAKPiBBbmQgYmVsb3cuIEFuZCBp biBjYXNlIGlmIHRoZXJlIGlzIGEgbmV3IHByb3Bvc2FsIHRvIGhhdmUKPiAKPiAJaWYgKCFuYXJn c19jb3VudCkKCkkgbWVhbnQKCglpZiAoIW5hcmdzX3Byb3ApCgpoZXJlIG9mIGNvdXJzZS4KCj4g CQlhcmdzX2NvdW50ID0gYWNwaV9md25vZGVfZ2V0X2FyZ3NfY291bnQoZGV2aWNlLCBuYXJnc19w cm9wKTsKPiAKPiB0aGF0IGlzIGV4YWN0bHkgd2hhdCBJIGFza2VkIHRvIGRyb3AgYXMgaXQncyBp bmNsdWRlZCBpbiB0aGUKPiBhY3BpX2Z3bm9kZV9nZXRfYXJnc19jb3VudCgpIGFscmVhZHksIGku ZS4gbm8gbmVlZCB0byBjaGVjayB0aGlzIGluCj4gdGhlIGNhbGxlciBhbmQgaW4gdGhlIGNhbGxl ZS4KPiAKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgaWYgKHJldCA8IDApCj4gPiA+ICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHJldDsKCi0tIApXaXRoIEJlc3Qg UmVnYXJkcywKQW5keSBTaGV2Y2hlbmtvCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtcmlzY3YK