From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 07AD52857DA; Wed, 2 Jul 2025 13:19:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.175.24.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751462369; cv=none; b=Enbus/O4SKoTt5+dk9mia0nXTUAsLaTTcUxka645Nc/DKC89zghRpWvOgN8fwPa9OLfPNHCgPT8VLWVn36kEVbS8P1lIUp+t47Nr6BTLZiox9biyz7enDoG9eFBL+06VK09ZLI+fNG82J6VRBZMdZc3g7M73ukWnJwpUQcSX1kY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751462369; c=relaxed/simple; bh=w7XgPwloDUij0Z+gHy5bOJpLrITKLh+THakaSZhTow8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u8G3iA/Att34Ag5nOGCyFbDMyaAQgLVy6r2oR65vvd37Aevsz6rkwi7a4b6vdY4pbXyqFvnpqPJPRcPGnr65vjXybBQLVud40vt7FnsRBYCcXok9mj1SOUqAjhtDwCKTCSRmfT63crmQKKiQcpyoLDWlgNznCnhvAAgeorZ2FMY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de; spf=pass smtp.mailfrom=alpha.franken.de; arc=none smtp.client-ip=193.175.24.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alpha.franken.de Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1uWwab-00058K-00; Wed, 02 Jul 2025 14:29:25 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 6ECD3C0B23; Wed, 2 Jul 2025 14:06:28 +0200 (CEST) Date: Wed, 2 Jul 2025 14:06:28 +0200 From: Thomas Bogendoerfer To: Shiji Yang Cc: linux-mips@vger.kernel.org, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, John Crispin , Linus Walleij , Mark Brown , linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/16] MIPS: vpe-mt: mark vpe_free() and vpe_stop() as static Message-ID: References: Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jun 18, 2025 at 10:53:25PM +0800, Shiji Yang wrote: > These functions are only used in the current source file "vpe-mt.c". > Do not export them and mark them as static to silence the missing > prototypes warnings: you are breaking the whole idea of this interface, The functions are exported for other kernel modules. By removing it you break them. If we know that this interface is unsued, we should remove the whole kernel module, but I don't know if it used somewhere. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]