From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB4A42750F2; Wed, 2 Jul 2025 12:56:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751461018; cv=none; b=POeOYOAVSCXhfBzAZBcT6bwBoAEtCj2Z+NvO8Bail43kN5c1MmVSr1WcQANoIPzCwLmbPoINgmkOPQM31nqwOVT9URXTzYmjgOL+9ufkYequsfc1jA7p7ZgdouOw//8IkLvNNKRTUoUr6wLwLQSDk6mfytt252DfVu9Z4RW0g4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751461018; c=relaxed/simple; bh=87AuNJuW+2yV1B9Zb2+kKYqb3dCQ3S9+ENTr/v9ygw8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VoG8qMVN4WPFh3B7mTyCZde3awc1Vl9lMXCLfN+EBYM5nYIDNOD/ZTeq9T7JPV130OQ90rLJDokUKWa+E/+jGfI8MfPlcV5xg2dUJfV4mytrvky3RZHrzdEGfZG40sVNil2+J4At71+hHqT2VKoL6UA/6g+pT9uLO5l0lou0wB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=A7MSSLLj; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="A7MSSLLj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751461017; x=1782997017; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=87AuNJuW+2yV1B9Zb2+kKYqb3dCQ3S9+ENTr/v9ygw8=; b=A7MSSLLjgmgy1cI4PG+rH5xJN3O9HtYltk0DJ9+Cn4E1Z4afNNH7NZtZ +hpvmsQCIaLuCIakotv07WQVRIgRdH30mprFQl0UNZ+YF+Io4N8EdvRh7 sWU8rk0Y1eN45idjFU6JbYhW4RLhBZbzjF+q5ymeEgFbbZq0Rfx7pGsSU SYhQv44cEDiOD6wf527r0vnZe2TU379hAnZD+VwydipiPvRouAcH1+wbT 5lSPZ8r5ydrC2h6czEOJ0Cs7KwjXeGGCeYBRB4jz33F7n186CNu9o+e+i Ig8cUnTcWlvN0XqecDIRQ1eD4wIUeBLSrPLSrexy4w1iBR9rqg51/VPZd Q==; X-CSE-ConnectionGUID: xVFwBIAiRP6ETwkCqRFZHA== X-CSE-MsgGUID: WdS/eiK6QIW9xIn/er9tiA== X-IronPort-AV: E=McAfee;i="6800,10657,11482"; a="79193524" X-IronPort-AV: E=Sophos;i="6.16,281,1744095600"; d="scan'208";a="79193524" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2025 05:56:46 -0700 X-CSE-ConnectionGUID: k5aMYtXJR2qEFNakZQpjgw== X-CSE-MsgGUID: aq3oM6NuTeeQ7eQWflv3ig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,281,1744095600"; d="scan'208";a="158331640" Received: from smile.fi.intel.com ([10.237.72.52]) by fmviesa005.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2025 05:56:40 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1uWx0t-0000000BvFQ-3atU; Wed, 02 Jul 2025 15:56:35 +0300 Date: Wed, 2 Jul 2025 15:56:35 +0300 From: Andy Shevchenko To: "Rafael J. Wysocki" Cc: Anup Patel , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jassi Brar , Thomas Gleixner , Mika Westerberg , Linus Walleij , Bartosz Golaszewski , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Palmer Dabbelt , Paul Walmsley , Alexandre Ghiti , Len Brown , Sunil V L , Rahul Pathak , Leyfoon Tan , Atish Patra , Andrew Jones , Samuel Holland , Anup Patel , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 15/24] ACPI: property: Add support for cells property Message-ID: References: <20250702051345.1460497-1-apatel@ventanamicro.com> <20250702051345.1460497-16-apatel@ventanamicro.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Jul 02, 2025 at 02:39:30PM +0200, Rafael J. Wysocki wrote: > On Wed, Jul 2, 2025 at 1:38 PM Andy Shevchenko > wrote: > > On Wed, Jul 02, 2025 at 12:20:55PM +0200, Rafael J. Wysocki wrote: > > > On Wed, Jul 2, 2025 at 7:16 AM Anup Patel wrote: ... > > > > static int acpi_fwnode_get_reference_args(const struct fwnode_handle *fwnode, > > > > const char *propname, const char *nargs_prop, > > > > unsigned int args_count, unsigned int index, > > > > > > const struct acpi_device_data *data; > > > > struct fwnode_handle *ref_fwnode; > > > > struct acpi_device *device; > > > > + unsigned int nargs_count; > > > > int ret, idx = 0; > > > > > > + nargs_count = acpi_fwnode_get_args_count(device, nargs_prop); > > > > > > I think it should work the same way as it used to for the callers that > > > pass args_count, so maybe > > > > > > if (!args_count) > > > args_count = acpi_fwnode_get_args_count(device, nargs_prop); > > > > But this is different variable. > > Of course it is different. It is an acpi_fwnode_get_reference_args() parameter. > > > > > element++; > > > > - > > > > ret = acpi_get_ref_args(idx == index ? args : NULL, > > > > acpi_fwnode_handle(device), > > > > - &element, end, args_count); > > > > + &element, end, > > > > + nargs_count ? nargs_count : args_count); > > > > > > And this change would not be necessary? > > > > This is not the same check as proposed above. > > No, it is not. > > It just makes the function work the same way it did before the change > for the callers who passed nozero args_count and so they might be > forgiven expecting that it would be taken into account. I see your point now. But do we have such a user? I dunno. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F8E5C83F04 for ; Wed, 2 Jul 2025 14:06:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NT6x9fexzLUAcppwtLERyzsFbraRMhSUbcmnm7VBkqw=; b=Hx7aQPWneila7J hLMpmCptfd7kn84WshKfDBk6Rn8HJEALHCmSnWcZ86mG8KbYkouvCSpTx4n6lH1IoyhC+5+dl39+/ ZUNsXdOMGPNmuDoxrbduA7mNDFUl2hVtIJZd8tvxa5x99HxHzdifGD/DX8TGBnxvrPztHq3UEjcJN YFHoiZb96aKhfCuT/g4e8SYuDVbzv1/oF4eiUh2UEms33MkH73nOqUDBd9+7OSVHierT7kmWLlFlh QUE86jjwdW0EVwmcuxLRsoZFxLb6T0RABnsPiJ1ASenPuT/ABxQsj3h3nf1lJMx19CM7qdy+BNHLJ g22pAyeajzQk8ABFyOgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWy6H-00000008ZZL-2Hrv; Wed, 02 Jul 2025 14:06:13 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWx1M-00000008NRA-3Ry4 for linux-riscv@bombadil.infradead.org; Wed, 02 Jul 2025 12:57:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=Q9DYzp0L6H5ExQxYi8Nrspzh1pluzAgU9TTqpo7nuEc=; b=adsM+JLqrLeDCaD4EKxmfB2mtn y6Ocums/X25NxvOhfrEmAf4c18TUhZKH5SBCXuFlaJfKrNpRqltmIp8JK5NPWDUjl99Fe8Kks1KjE 1dGIiaRsjKrV57hXwQUWBG4CdOH5CUoEbvdQl2yEjMOONQoQ/wR9ypBXYQc4DzzduIZ7HzMHxJHCn cQkDPwvQ+GXCU8jzx3aEcEx1MX4UEesWQkzs6VwgOKMOYCjSg04Gpc2TPS0RhMMpxVyB5MSH/TvWi rU69Z20dUQaGrTXr8X+BgeMyiz96EhvPcWqW7Nc55ybjZw+NiqgU3cEWjhzQl7zzh65oMRHwOdo2R Y7xsNyJg==; Received: from mgamail.intel.com ([192.198.163.7]) by desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWx1J-00000007NgJ-2Iy0 for linux-riscv@lists.infradead.org; Wed, 02 Jul 2025 12:57:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751461021; x=1782997021; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=87AuNJuW+2yV1B9Zb2+kKYqb3dCQ3S9+ENTr/v9ygw8=; b=bAcNUXU8c0UutSDtZHPpxEgghE8Ivk5mzeNJebRBmmTyXlAapkXRMDTV CWKyBsYrozzFEhf6i9GKR+bEPn5yIV9dAsmE0EsxOveb9sbaE8YSwMlc5 lgN8yD+qpsCnvrkHDlakUi8i5A6sTxLDMM+x7PIUhBQy1A6ETw7KHGvo6 4X0/pjYbJ3b0ty90M4oxVBhVGp1wftVM0G+6XOP1chD4MkjnaKiKxol/V 55vAsmMwAwBl8edSMMdiASTmo2pi1CDjME1chtFDlWp1875fC/qLF6kkw p+BUXMBmOu1x1P2zVXLquz4egZVM+xbSZBG67mTnSG6qyRTRfnwuiVPrU w==; X-CSE-ConnectionGUID: cn9wKZ75TuG2HwNelWrDbg== X-CSE-MsgGUID: h3s99CI7SaqnGsfRvGODbw== X-IronPort-AV: E=McAfee;i="6800,10657,11482"; a="79193527" X-IronPort-AV: E=Sophos;i="6.16,281,1744095600"; d="scan'208";a="79193527" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2025 05:56:46 -0700 X-CSE-ConnectionGUID: k5aMYtXJR2qEFNakZQpjgw== X-CSE-MsgGUID: aq3oM6NuTeeQ7eQWflv3ig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,281,1744095600"; d="scan'208";a="158331640" Received: from smile.fi.intel.com ([10.237.72.52]) by fmviesa005.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2025 05:56:40 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1uWx0t-0000000BvFQ-3atU; Wed, 02 Jul 2025 15:56:35 +0300 Date: Wed, 2 Jul 2025 15:56:35 +0300 From: Andy Shevchenko To: "Rafael J. Wysocki" Subject: Re: [PATCH v7 15/24] ACPI: property: Add support for cells property Message-ID: References: <20250702051345.1460497-1-apatel@ventanamicro.com> <20250702051345.1460497-16-apatel@ventanamicro.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250702_135701_985192_6DCB0E87 X-CRM114-Status: GOOD ( 23.17 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Atish Patra , Michael Turquette , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org, Rob Herring , Alexandre Ghiti , Anup Patel , Bartosz Golaszewski , Jassi Brar , linux-acpi@vger.kernel.org, Linus Walleij , Andrew Jones , devicetree@vger.kernel.org, Conor Dooley , Leyfoon Tan , Paul Walmsley , Thomas Gleixner , Mika Westerberg , Anup Patel , Stephen Boyd , linux-kernel@vger.kernel.org, Samuel Holland , Palmer Dabbelt , Krzysztof Kozlowski , Rahul Pathak , Len Brown Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKdWwgMDIsIDIwMjUgYXQgMDI6Mzk6MzBQTSArMDIwMCwgUmFmYWVsIEouIFd5c29j a2kgd3JvdGU6Cj4gT24gV2VkLCBKdWwgMiwgMjAyNSBhdCAxOjM44oCvUE0gQW5keSBTaGV2Y2hl bmtvCj4gPGFuZHJpeS5zaGV2Y2hlbmtvQGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gPiBPbiBX ZWQsIEp1bCAwMiwgMjAyNSBhdCAxMjoyMDo1NVBNICswMjAwLCBSYWZhZWwgSi4gV3lzb2NraSB3 cm90ZToKPiA+ID4gT24gV2VkLCBKdWwgMiwgMjAyNSBhdCA3OjE24oCvQU0gQW51cCBQYXRlbCA8 YXBhdGVsQHZlbnRhbmFtaWNyby5jb20+IHdyb3RlOgoKLi4uCgo+ID4gPiA+ICBzdGF0aWMgaW50 IGFjcGlfZndub2RlX2dldF9yZWZlcmVuY2VfYXJncyhjb25zdCBzdHJ1Y3QgZndub2RlX2hhbmRs ZSAqZndub2RlLAo+ID4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGNvbnN0IGNoYXIgKnByb3BuYW1lLCBjb25zdCBjaGFyICpuYXJnc19wcm9wLAo+ID4gPiA+ ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBh cmdzX2NvdW50LCB1bnNpZ25lZCBpbnQgaW5kZXgsCj4gPgo+ID4gPiA+ICAgICAgICAgY29uc3Qg c3RydWN0IGFjcGlfZGV2aWNlX2RhdGEgKmRhdGE7Cj4gPiA+ID4gICAgICAgICBzdHJ1Y3QgZndu b2RlX2hhbmRsZSAqcmVmX2Z3bm9kZTsKPiA+ID4gPiAgICAgICAgIHN0cnVjdCBhY3BpX2Rldmlj ZSAqZGV2aWNlOwo+ID4gPiA+ICsgICAgICAgdW5zaWduZWQgaW50IG5hcmdzX2NvdW50Owo+ID4g PiA+ICAgICAgICAgaW50IHJldCwgaWR4ID0gMDsKPiA+Cj4gPiA+ID4gKyAgICAgICAgICAgICAg ICAgICAgICAgbmFyZ3NfY291bnQgPSBhY3BpX2Z3bm9kZV9nZXRfYXJnc19jb3VudChkZXZpY2Us IG5hcmdzX3Byb3ApOwo+ID4gPgo+ID4gPiBJIHRoaW5rIGl0IHNob3VsZCB3b3JrIHRoZSBzYW1l IHdheSBhcyBpdCB1c2VkIHRvIGZvciB0aGUgY2FsbGVycyB0aGF0Cj4gPiA+IHBhc3MgYXJnc19j b3VudCwgc28gbWF5YmUKPiA+ID4KPiA+ID4gaWYgKCFhcmdzX2NvdW50KQo+ID4gPiAgICAgICAg IGFyZ3NfY291bnQgPSBhY3BpX2Z3bm9kZV9nZXRfYXJnc19jb3VudChkZXZpY2UsIG5hcmdzX3By b3ApOwo+ID4KPiA+IEJ1dCB0aGlzIGlzIGRpZmZlcmVudCB2YXJpYWJsZS4KPiAKPiBPZiBjb3Vy c2UgaXQgaXMgZGlmZmVyZW50LiAgSXQgaXMgYW4gYWNwaV9md25vZGVfZ2V0X3JlZmVyZW5jZV9h cmdzKCkgcGFyYW1ldGVyLgo+IAo+ID4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIGVsZW1l bnQrKzsKPiA+ID4gPiAtCj4gPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgcmV0ID0gYWNw aV9nZXRfcmVmX2FyZ3MoaWR4ID09IGluZGV4ID8gYXJncyA6IE5VTEwsCj4gPiA+ID4gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYWNwaV9md25vZGVfaGFu ZGxlKGRldmljZSksCj4gPiA+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgJmVsZW1lbnQsIGVuZCwgYXJnc19jb3VudCk7Cj4gPiA+ID4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJmVsZW1lbnQsIGVuZCwKPiA+ ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBuYXJn c19jb3VudCA/IG5hcmdzX2NvdW50IDogYXJnc19jb3VudCk7Cj4gPiA+Cj4gPiA+IEFuZCB0aGlz IGNoYW5nZSB3b3VsZCBub3QgYmUgbmVjZXNzYXJ5Pwo+ID4KPiA+IFRoaXMgaXMgbm90IHRoZSBz YW1lIGNoZWNrIGFzIHByb3Bvc2VkIGFib3ZlLgo+IAo+IE5vLCBpdCBpcyBub3QuCj4gCj4gSXQg anVzdCBtYWtlcyB0aGUgZnVuY3Rpb24gd29yayB0aGUgc2FtZSB3YXkgaXQgZGlkIGJlZm9yZSB0 aGUgY2hhbmdlCj4gZm9yIHRoZSBjYWxsZXJzIHdobyBwYXNzZWQgbm96ZXJvIGFyZ3NfY291bnQg YW5kIHNvIHRoZXkgbWlnaHQgYmUKPiBmb3JnaXZlbiBleHBlY3RpbmcgdGhhdCBpdCB3b3VsZCBi ZSB0YWtlbiBpbnRvIGFjY291bnQuCgpJIHNlZSB5b3VyIHBvaW50IG5vdy4gQnV0IGRvIHdlIGhh dmUgc3VjaCBhIHVzZXI/IEkgZHVubm8uCgotLSAKV2l0aCBCZXN0IFJlZ2FyZHMsCkFuZHkgU2hl dmNoZW5rbwoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2 Cg==