From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB77C1C5D62; Wed, 2 Jul 2025 13:08:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751461713; cv=none; b=cdn3w6DyL7UfthZRe7dCAemsAY9+R2qaaJ4lVfXKhVbQNQX4k/hRuIr/VlPuoyYQD4gbvQrsW4AeKVM6C3Ue9Utw72Am29w2XcMS5ekQRa/ILilfrVMFmm/Jcy1keAiTskZfcMsIVYSyKLuiAYCKxAZF4dqWpbfv94GmMU9CAxA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751461713; c=relaxed/simple; bh=OiNoLYPohzS6O6OmHodoyDxPsEF4t/bkOwQkU4sWqc0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tlXnRTMftWige+LawKqho8FFHkKbxSkqsH3lUPqaeqsP1NA2ObYl9mb1Cj9jQZnEigTINtCgCjD1MDLNHymEwxNVgBzKwptVsRebJLxz3mHy2Z/ntw/SH9dlWuBtUR2L1OKOVJ6kYX3wCadSPCwsHjbSri1HUiEKk9u0h88lbMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=LLsV31Nn; arc=none smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="LLsV31Nn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751461712; x=1782997712; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=OiNoLYPohzS6O6OmHodoyDxPsEF4t/bkOwQkU4sWqc0=; b=LLsV31Nno3+2IxWfKF3b30yhacr5Hhnb52vN0GZKt/O2ghtQ0vOML3Jc 1z+FGe/QwMaeBFQSan1W/3Q16eYtUgKIQDpdE8Kedxm+hfrUrvD9gG5pV o5s4Se2lzsYliD3Ifz3LpdufiRYlUa61Wk99TC2K7/hxegNnh0tLL1zq9 3Sh8KrDlWDOjXUGOwCduZLLHphIOAqdBGp+xEGX/RKfEY3W7HC6janDcb TldqAZD+uGxQtKAdSh58rmcmCMNyfqN267kP/pr3EQsgUg2ucCdriTEwX Yc8uO3I9hAjrUBjFxGDuPlI5Bq6sKegOEfNmtszkgYSAdX2MAnIBsNihX A==; X-CSE-ConnectionGUID: 91gHU4C9SiiKJWTyw/Bvqg== X-CSE-MsgGUID: KkfpCz9/Q0aP58BofifAAA== X-IronPort-AV: E=McAfee;i="6800,10657,11482"; a="64448818" X-IronPort-AV: E=Sophos;i="6.16,281,1744095600"; d="scan'208";a="64448818" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2025 06:08:20 -0700 X-CSE-ConnectionGUID: /OlEb6b5TiuRhsJx8CCehg== X-CSE-MsgGUID: D+4XGKXZTUG7f6nocLrJWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,281,1744095600"; d="scan'208";a="159771935" Received: from smile.fi.intel.com ([10.237.72.52]) by orviesa005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2025 06:08:14 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1uWxC4-0000000BvT0-2jDn; Wed, 02 Jul 2025 16:08:08 +0300 Date: Wed, 2 Jul 2025 16:08:08 +0300 From: Andy Shevchenko To: Anup Patel Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jassi Brar , Thomas Gleixner , "Rafael J . Wysocki" , Mika Westerberg , Linus Walleij , Bartosz Golaszewski , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Palmer Dabbelt , Paul Walmsley , Alexandre Ghiti , Len Brown , Sunil V L , Rahul Pathak , Leyfoon Tan , Atish Patra , Andrew Jones , Samuel Holland , Anup Patel , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 10/24] clk: Add clock driver for the RISC-V RPMI clock service group Message-ID: References: <20250702051345.1460497-1-apatel@ventanamicro.com> <20250702051345.1460497-11-apatel@ventanamicro.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250702051345.1460497-11-apatel@ventanamicro.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Jul 02, 2025 at 10:43:31AM +0530, Anup Patel wrote: > > The RPMI specification defines a clock service group which can be > accessed via SBI MPXY extension or dedicated S-mode RPMI transport. > > Add mailbox client based clock driver for the RISC-V RPMI clock > service group. Now it looks much better! Reviewed-by: Andy Shevchenko One nit-pick below. ... > +/* > + * rpmi_clk_rates represents the rates format > + * as specified by the RPMI specification. > + * No other format conversion(eg. linear_range) is > + * required to avoid to and fro conversion. conversion appears twice. I would suggest use this: * No other data format (e.g., struct linear_range) is * required to avoid to and from conversion. > + */ -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3E5DC83F04 for ; Wed, 2 Jul 2025 14:21:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AT2NUwSgKpzQG3fciXXz3kl6ekFiexcjn1fwVDbdY74=; b=d3B0BUnVKkTuor fxYjTZRD72ROSiCUIUFYWYQg05hJdoTilKmhR6yB3263mHwXl4izGpKpRebw4uG/S+Z0dm2DZTwIm AyoffgBBXEQ1TJ3Oi/2L/CEkrWYz1yF3C4ub8KbeK0NVoZNAeOTtR960FyrVL2uPxmQK8lRzq6jaC 0kjcuA5ufbSK4L8lhshWEeFxHGXpFBNNCqeYUrEpSQW2bAZsT6RebSTMR9obAisQAqcJFlSOnCQd3 a30ljDJP1vqpslvIy96M12sUys3PP4kLAhfhC9ZViCtwckIUoEnYb1KsdCT4v9msodAmx31iH8ZDt R+8xVs5L4b0h+3iISxRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWyKn-00000008c4F-2JDz; Wed, 02 Jul 2025 14:21:13 +0000 Received: from mgamail.intel.com ([192.198.163.9]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWxCQ-00000008Ot1-2pa1 for linux-riscv@lists.infradead.org; Wed, 02 Jul 2025 13:08:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751461710; x=1782997710; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=OiNoLYPohzS6O6OmHodoyDxPsEF4t/bkOwQkU4sWqc0=; b=cZ/tcKLm3PNNwdl39dB8ipOUS0WQtzZqQ5OwjtkXGRVwVwcENwVAdP9j P63QJ5CtyTkdz/N+LRKi9RWhV2ETFfqal1mT6H3X8tNW5YFw1chSWOTdO IIjSqEst4wbBWrpi4SguX2OcH+5LOaG7wGVKcpswbpqr2Ex/l0XHvbbS9 ZPenZvxU9fGYG8hFdVQAjGFwTg1e+bLq7Rlq5f2txqjnhMaIvHtCiBK+i w6zM5JbM1vfcWzz+jgg0RrCwFEFyuizTSi7cOiIcww3tI3Ia0ic2O5YeI Z/PEX0qKvwKtVuQZU1oNvPC8IE4rqv7EwfXeW6DIAUI1FGU4rIsN37p3O Q==; X-CSE-ConnectionGUID: BmXiJLaoQEq5LU/mCZ3zWg== X-CSE-MsgGUID: ADGtYVeoRaGSdNx6lpwPYw== X-IronPort-AV: E=McAfee;i="6800,10657,11482"; a="64448824" X-IronPort-AV: E=Sophos;i="6.16,281,1744095600"; d="scan'208";a="64448824" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2025 06:08:20 -0700 X-CSE-ConnectionGUID: /OlEb6b5TiuRhsJx8CCehg== X-CSE-MsgGUID: D+4XGKXZTUG7f6nocLrJWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,281,1744095600"; d="scan'208";a="159771935" Received: from smile.fi.intel.com ([10.237.72.52]) by orviesa005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2025 06:08:14 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1uWxC4-0000000BvT0-2jDn; Wed, 02 Jul 2025 16:08:08 +0300 Date: Wed, 2 Jul 2025 16:08:08 +0300 From: Andy Shevchenko To: Anup Patel Subject: Re: [PATCH v7 10/24] clk: Add clock driver for the RISC-V RPMI clock service group Message-ID: References: <20250702051345.1460497-1-apatel@ventanamicro.com> <20250702051345.1460497-11-apatel@ventanamicro.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250702051345.1460497-11-apatel@ventanamicro.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250702_060830_759820_2832F3F6 X-CRM114-Status: GOOD ( 11.24 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jassi Brar , Atish Patra , Michael Turquette , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org, Rob Herring , Alexandre Ghiti , Anup Patel , Bartosz Golaszewski , "Rafael J . Wysocki" , linux-acpi@vger.kernel.org, Linus Walleij , Andrew Jones , devicetree@vger.kernel.org, Conor Dooley , Leyfoon Tan , Paul Walmsley , Thomas Gleixner , Mika Westerberg , Stephen Boyd , linux-kernel@vger.kernel.org, Samuel Holland , Palmer Dabbelt , Krzysztof Kozlowski , Rahul Pathak , Len Brown Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, Jul 02, 2025 at 10:43:31AM +0530, Anup Patel wrote: > > The RPMI specification defines a clock service group which can be > accessed via SBI MPXY extension or dedicated S-mode RPMI transport. > > Add mailbox client based clock driver for the RISC-V RPMI clock > service group. Now it looks much better! Reviewed-by: Andy Shevchenko One nit-pick below. ... > +/* > + * rpmi_clk_rates represents the rates format > + * as specified by the RPMI specification. > + * No other format conversion(eg. linear_range) is > + * required to avoid to and fro conversion. conversion appears twice. I would suggest use this: * No other data format (e.g., struct linear_range) is * required to avoid to and from conversion. > + */ -- With Best Regards, Andy Shevchenko _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv