All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Thomas Richter <tmricht@linux.ibm.com>
Cc: Ian Rogers <irogers@google.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	agordeev@linux.ibm.com, gor@linux.ibm.com, hca@linux.ibm.com
Subject: Re: [Ping][PATCH] perf list: Add IBM z17 event descriptions
Date: Wed, 2 Jul 2025 10:03:35 -0700	[thread overview]
Message-ID: <aGVmZ_VQiFfYCSaS@google.com> (raw)
In-Reply-To: <a63ecea7-8ab0-4691-897c-09f6efa82068@linux.ibm.com>

Hello,

On Wed, Jul 02, 2025 at 10:57:58AM +0200, Thomas Richter wrote:
> On 6/27/25 18:55, Ian Rogers wrote:
> > On Fri, Jun 27, 2025 at 1:13 AM Thomas Richter <tmricht@linux.ibm.com> wrote:
> >>
> >> On 6/24/25 08:35, Thomas Richter wrote:
> >>
> >> Gently Ping
> >>
> >> Ian, I have responded to your comments some days ago.
> > 
> > Thanks Thomas, minor nit in your explanation the events must exist as
> > they are in json, but the json events are only exposed if the PMU is
> > present, so the has_event is more of a has_pmu test. Maybe we should
> > add a function like this to the metrics to make this kind of case
> > clearer. Maybe `perf list` should test the events of a metric and hide
> > metrics when the events aren't available to avoid the have_event
> > logic. I'm a bit uncomfortable with that as the events may not be
> > available because of permission issues, but it'd still be useful to
> > know the metrics are around. Anyway I'm digressing.
> > 
> > Reviewed-by: Ian Rogers <irogers@google.com>
> > 
> > Thanks,
> > Ian
> > 
> 
> Arnaldo, Namhyung,
> 
> with Ian Rogers Reviewed-by: approval, it is possible to
> accept this patch soon, so it will land in the next merge-window.
> 
> That will give me an commit-id which I need for my addon work.
> 
> Thanks a lot for your help.

Sorry about the delay, I'll process this soon.

Thanks,
Namhyung


  reply	other threads:[~2025-07-02 17:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-23 13:27 [PATCH] perf list: Add IBM z17 event descriptions Thomas Richter
2025-06-23 17:53 ` Ian Rogers
2025-06-24  6:35   ` Thomas Richter
2025-06-27  8:13     ` [Ping][PATCH] " Thomas Richter
2025-06-27 16:55       ` Ian Rogers
2025-07-02  8:57         ` Thomas Richter
2025-07-02 17:03           ` Namhyung Kim [this message]
2025-07-03 18:16 ` [PATCH] " Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aGVmZ_VQiFfYCSaS@google.com \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=irogers@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=tmricht@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.