Re: [PATCH v5 06/10] drm/xe/xe_late_bind_fw: Reload late binding fw in rpm resume

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Wed, Jul 02, 2025 at 10:22:12PM +0530, Badal Nilawar wrote:
> Reload late binding fw during runtime resume.
> 
> Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
> ---
> v5: Flush worker in rpm suspend is not needed any more as
>     xe_late_bind_fw_load gets the rpm ref before queuing worker
>     to ensure worker completes lb fw loading.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_late_bind_fw.c | 2 +-
>  drivers/gpu/drm/xe/xe_late_bind_fw.h | 1 +
>  drivers/gpu/drm/xe/xe_pm.c           | 4 ++++
>  3 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw.c b/drivers/gpu/drm/xe/xe_late_bind_fw.c
> index 56166816a535..3fb84d2f0a76 100644
> --- a/drivers/gpu/drm/xe/xe_late_bind_fw.c
> +++ b/drivers/gpu/drm/xe/xe_late_bind_fw.c
> @@ -82,7 +82,7 @@ static int xe_late_bind_fw_num_fans(struct xe_late_bind *late_bind)
>  		return 0;
>  }
>  
> -static void xe_late_bind_wait_for_worker_completion(struct xe_late_bind *late_bind)
> +void xe_late_bind_wait_for_worker_completion(struct xe_late_bind *late_bind)
>  {
>  	struct xe_device *xe = late_bind_to_xe(late_bind);
>  	struct xe_late_bind_fw *lbfw;
> diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw.h b/drivers/gpu/drm/xe/xe_late_bind_fw.h
> index 28d56ed2bfdc..07e437390539 100644
> --- a/drivers/gpu/drm/xe/xe_late_bind_fw.h
> +++ b/drivers/gpu/drm/xe/xe_late_bind_fw.h
> @@ -12,5 +12,6 @@ struct xe_late_bind;
>  
>  int xe_late_bind_init(struct xe_late_bind *late_bind);
>  int xe_late_bind_fw_load(struct xe_late_bind *late_bind);
> +void xe_late_bind_wait_for_worker_completion(struct xe_late_bind *late_bind);
>  
>  #endif
> diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
> index ff749edc005b..734fe259600e 100644
> --- a/drivers/gpu/drm/xe/xe_pm.c
> +++ b/drivers/gpu/drm/xe/xe_pm.c
> @@ -20,6 +20,7 @@
>  #include "xe_gt.h"
>  #include "xe_guc.h"
>  #include "xe_irq.h"
> +#include "xe_late_bind_fw.h"
>  #include "xe_pcode.h"
>  #include "xe_pxp.h"
>  #include "xe_trace.h"
> @@ -550,6 +551,9 @@ int xe_pm_runtime_resume(struct xe_device *xe)
>  
>  	xe_pxp_pm_resume(xe->pxp);
>  
> +	if (xe->d3cold.allowed)
> +		xe_late_bind_fw_load(&xe->late_bind);
> +
>  out:
>  	xe_rpm_lockmap_release(xe);
>  	xe_pm_write_callback_task(xe, NULL);
> -- 
> 2.34.1
>