From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6833C83F03 for ; Wed, 2 Jul 2025 21:44:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4BF4910E074; Wed, 2 Jul 2025 21:44:22 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="MeW8xV3I"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by gabe.freedesktop.org (Postfix) with ESMTPS id 374B310E074 for ; Wed, 2 Jul 2025 21:44:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751492661; x=1783028661; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=6+cBFRq7Dz+0KsXUqyXV9v5WLcxfCfoFhz9Obgu8FOQ=; b=MeW8xV3I0xHCSucJM7AJ6pu1N46zwADQ5DQc0GXzqpTESFW4Zewhnsw6 lnR+H28eFNHdZh8ZBag3bk+8JgDWzGSjtpGsPxPVo36TyOk1qDf9vPfVB 9WczKuuxATze4uSAWnn2//QsHC7yBtIolQzP19PCw8eTEsHwsXAH0xmj8 oLuJzFC7kuBffmIJAW/MkGm4jaj5ihHUeX/+L0mh4jFJx6KhIqMo6j9a0 sqDe8h4k090Hq5VgdrlGCZfPRtGPu1mjlMIptSH4Cr56M3AePjUC7Ilzh Ngo4PjVGZ0HhCxqN8qnXvOUR/fWFfSLjKFV/Rofk0s6GW1g3pKOpsdsMc w==; X-CSE-ConnectionGUID: +RpOuA41QZ6ej67kAiw8nA== X-CSE-MsgGUID: cuvyEC7fT4Obn40PJLIOhw== X-IronPort-AV: E=McAfee;i="6800,10657,11482"; a="71378452" X-IronPort-AV: E=Sophos;i="6.16,282,1744095600"; d="scan'208";a="71378452" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2025 14:44:21 -0700 X-CSE-ConnectionGUID: DF12oa4JRSOxisA+eOSuAQ== X-CSE-MsgGUID: smt9prZZS5iP+hK0LAbbTQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,282,1744095600"; d="scan'208";a="158474232" Received: from orsmsx902.amr.corp.intel.com ([10.22.229.24]) by fmviesa005.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2025 14:44:21 -0700 Received: from ORSMSX903.amr.corp.intel.com (10.22.229.25) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25; Wed, 2 Jul 2025 14:44:20 -0700 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25 via Frontend Transport; Wed, 2 Jul 2025 14:44:20 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (40.107.212.88) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25; Wed, 2 Jul 2025 14:44:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=s/6r0ba0RP2tLQFK/mDlt5hk4YAP2apA3s6ZAa5uS5DzUkpCA8OPNQk+eUyTFPunwtvSSanR+JU/3PoCjH/TaRJHbXCoUwPnHwXYGkNDfV4YFGzGWNAoxWw8VtoG66o6AYJiJ3SLYe1TUAvHMB/5TKLi0wb9Ig/ktzBhmJVlHtWRGpsgGA8XrBfJkZTPpsuDRV4lIetXJzuwjuJx3gNIa8J4EXXOApBQssw6e1PyV5gsunYWj3PRGl1Gp0wXxW2w6gjWYtTo18HUkZnrULmsyJeuPN6nAnjrsCt2YxYX62gZkFdBPFts84B9/OJiOMDhOiOaGHgi4kQigjK7Bqt7QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s++HTajqsNRTozsBORuaB6T3ZurLFmTsyAuRqOR+EME=; b=J2kGOtXtJEnBHYXH8JTwD7JX/AvpIauvv9y+zmYQsRF0PWyNK7gJMIGM39XxnlRFAD58pw/O6cm4fcY+zLRAWYsMFDDsRLCDRQPey1qHKzsZkoY82KML4Uof5wkFqHXwxoMdS1aYqiJUsJLG0GW24DQ+qfvnIRL+x6jVr3tN/EJb6r/E2aJC3Im0ZKgTr+645d02ATgj1w7xbJ5mr6IlMw/NH11tanrX7m7Hsj6k5j/DtR+4AfCrBBRf6WcaaSlK4Stb78NfUmldIgVX3GQbSqfOhR0ayPKKzrieO4H2iLl4Sy2MAeWipAQf5m2lO+llxrY6kskGH6+2DClQCd9uGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SA1PR11MB8427.namprd11.prod.outlook.com (2603:10b6:806:373::19) by CH0PR11MB8143.namprd11.prod.outlook.com (2603:10b6:610:193::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.26; Wed, 2 Jul 2025 21:44:03 +0000 Received: from SA1PR11MB8427.namprd11.prod.outlook.com ([fe80::b156:b61b:d462:b781]) by SA1PR11MB8427.namprd11.prod.outlook.com ([fe80::b156:b61b:d462:b781%5]) with mapi id 15.20.8880.021; Wed, 2 Jul 2025 21:44:03 +0000 Date: Wed, 2 Jul 2025 17:43:59 -0400 From: Rodrigo Vivi To: CC: Heikki Krogerus Subject: Re: =?utf-8?B?4pyXIENJLmNoZWNrcGF0Y2g=?= =?utf-8?Q?=3A?= warning for drm/xe: i2c support (rev6) Message-ID: References: <20250701122252.2590230-1-heikki.krogerus@linux.intel.com> <175137291692.123583.2949800642150017515@1538d3639d33> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <175137291692.123583.2949800642150017515@1538d3639d33> X-ClientProxiedBy: SJ0PR05CA0173.namprd05.prod.outlook.com (2603:10b6:a03:339::28) To SA1PR11MB8427.namprd11.prod.outlook.com (2603:10b6:806:373::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA1PR11MB8427:EE_|CH0PR11MB8143:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c62f674-7489-4be2-f3a5-08ddb9b18ff0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?POiGzYaWdxEht9vy8zQFsS6r5qNNza+OyP5ff4deuxMQqlFAi4VUSsOJX0bX?= =?us-ascii?Q?d1nZKdIBY8W1DcYpvP4r0DOiKrFACJGsHUkr4sKELZPRGWZLlNhKSdEEv/GI?= =?us-ascii?Q?v3RnqRdVvbSCcoegOTRop/RvZqBPUaoQNjOkBYDBzEpQ8R+cTUg7L+WWlxcI?= =?us-ascii?Q?RytRtBvdIOpY4E6F4YxiGpEe9ynGJFoBfStANbUTt1qRRM1bXAAX29xmxiA1?= =?us-ascii?Q?ECrQ/hBjCxLUXiBuYAGdtKHwMu/8zXB3fqnyK6eh/CKSNBEcIVdcn7aGOY13?= =?us-ascii?Q?2IuVycewjlqTnFkPU8byL++RdNZub6a3j3lWWOBwl3FP8bD+R+3urYIQnghT?= =?us-ascii?Q?NEB9qIvOsUoO0BHs80I6T2aJyyOpOjzcZ3KTJw/yaAClD/934gcTM1WAkHB7?= =?us-ascii?Q?45tAHhW9fE9dnAakN4tCVOaR5nAGBcg7FFenQ/Q69D70YHvuYDFWd2prNPpp?= =?us-ascii?Q?DCP4I5k0IWlVfCvfB6OoqkdVxr0gCRKdw7Vk5sR6VhCvd7xB2nZdWakdyerb?= =?us-ascii?Q?2jEI/cLhm/2zao410w940KIOuwIEg4nGKlmEX8pKx5nhA1vzDsRUC75GEy0Z?= =?us-ascii?Q?MEr9YroFndGVlKXhiFCRIGoSvK1gQKapVvnVCiW4KfkuQDLBG+XPAuNuyfv2?= =?us-ascii?Q?c1NMVLDGChsWozANFXhVdvEmxw7gt8S/g7fYSopYOUFtorYFHE+mdWtCvQbT?= =?us-ascii?Q?Pww/o5pv6gUg8HP+z76+mHzSUQp47Fm735tyIkvSEA7h7rlo5wz+Jku6nTpk?= =?us-ascii?Q?9dgoam5HcDTgpFU2O2+Y9W3pjcmYLyne/WGMcS0sX+Ym8gp3m0glTS768+10?= =?us-ascii?Q?uCCa4D7d8YOVeWFNXWdYiU/kwZs8PZA9gm2BeVAMz1Fv0aqotDlwQl/4iYHu?= =?us-ascii?Q?aI9Gqlfd+Nx1xKj3UP9uRoLLPz0hqjbKRFl6Qdm9/Q5F3yUhLhAwao6oNz4C?= =?us-ascii?Q?ovgE9shE5mk79PK7ShILOkTmEBbo6OEI01ZVoplzX8CkVZDP294PmxEigpyS?= =?us-ascii?Q?+14Qz/+njRV6rI723L4nqOe4EXMKpkgJ8lNS/U9NiAxlTZeGfgGhVFaOy09+?= =?us-ascii?Q?63B3kctDoo8acRPmTNvBkNGuf0IMB37morh9qxEk9xPtaw96iBt9AqffZl1M?= =?us-ascii?Q?B5dd02Q0B8w67G6z6HomlFmmvWKP+OU+CAvXT+osHut7RSNBh1eQjKSDz0Qp?= =?us-ascii?Q?MB/PdtAprdnRh0n0wibWnQIJzJjpwOFohcN+cy71n9KK4RsKYrR2rTZLoj2w?= =?us-ascii?Q?ZUsQgHBSmzTbmR+zRwTdwBfSDGpvBtIECvtyJolonJNmhH8olrWQ/Yooq/Rz?= =?us-ascii?Q?CQ3Z5TsLvz8dU2aogPqKm8QzB+TQZqwuZ3Y5S/YqOTwwIMcKxs9CPDfksONe?= =?us-ascii?Q?M3UyTqA=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR11MB8427.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5IF71ZQ+JDYCgAC90FF4NFcR05iv6v4Bsy69EEuCHil+2oyZd/85aLAPMILE?= =?us-ascii?Q?qYqmlsqb+InXNv3qjZuFI5IYgrHqRgn/HyN3nk602CWiw/gUGG6F4E891aQ3?= =?us-ascii?Q?vOcLpXzfR8xvzI1Iq16ZGd8NO0dOyfXfgz2zuKzEiVupF8ykBSZG61CgQeCe?= =?us-ascii?Q?8HTvVpVV79Lv356d++4mh+14UFyumDOCILyiBiyl4MWFlC6YVvyHGp3DvVrR?= =?us-ascii?Q?bUw+a6vm6Q2HVP41NclnVouAMu5gueGY3NR0Fcp51lUpYI8kyq+4Na7ir4FV?= =?us-ascii?Q?vlrdkByUxN3mBcIqCHSbkM8aEb5yLHhUz0/jlkMk6tXl4tQ0LgLzZZe9+ERy?= =?us-ascii?Q?JjrnMKTFc3C6L/nhjxs/WPLa+a4cK0GVCyNl67MJAHaYrBTJ3Hr+GrFBKSBl?= =?us-ascii?Q?vjwS1Vv9rl+AWX53AtVTdMRIRvnDUcZXKIY29Gs+dJQfXyrog1GHWLjrUPRS?= =?us-ascii?Q?E1SSYmxxfvA6XXMBrr2coPqgyy2TYtlzJ5bJYELNqx9Z0SD0EKfmdGOkjr9A?= =?us-ascii?Q?ERsEHY77IjcnqjBkKVDN6xTvpS7QdSE9UrrrbJzkgFpenF446NVjDCiOQQ64?= =?us-ascii?Q?bxiZZbc4NcD7ytip2d/JmIXVnWUUIhX3KWfe50Ea3KhwcsLnv630ADWJoF4y?= =?us-ascii?Q?CUW6J3x3p5IXg6OknFe6OczRx20m3nhnHUDf29r/hkkTrV2HxssYIDylg/+W?= =?us-ascii?Q?kguTAsmv26BvgfDVFd8s6cOPp8V43F8jHGtuAwVsMUnniDpIkSABKDrpxN3u?= =?us-ascii?Q?wI8A72S1kMmk2VcFz9LGWZbV0bi9ECKJdcHB5tMJuu9czqPEdQcoZEdD+N1u?= =?us-ascii?Q?9CIP8UvbEMFmF79RzMpQi8ZdHVttRj+LZGLhgqLxB1p5aeNegbogHHuQbc0i?= =?us-ascii?Q?qg5aYnBrZQGtI7+FMXwJ11Elh+hwyK3CybGf+ttxn9MtEqapbLKnF9VNE4YQ?= =?us-ascii?Q?/mEmdJUNe2xDi40DkuxmcrDbH22tGi5nBI+9Bk93oSlFrub2HtCno+8+8NSU?= =?us-ascii?Q?8RTjCjYVwaVCSjN4Flci1xAJk/+eb4uJjaZxyFxBamPG6jnc/NjnwsrEaAtD?= =?us-ascii?Q?10XmniPdt51YTbZWrM0W5B+r8hTNh8eieBv9oY3+kEdj4QK2UlhsOLn/jjdr?= =?us-ascii?Q?oz1Vsmxt19BwwHNwYMvIUcJn4EBjQgAG98V9KO0sjzV5pvc+NVNpaKGQHE4p?= =?us-ascii?Q?FBAdzcEzO81ctXmOi8uLICVW6ntmvnuZblx2t1SznG7x2nqP45223SvD9BmQ?= =?us-ascii?Q?hrF5+hZ6TEbFbcLpnbvxPPp6TWVXgblgmd53dMmTKE2MKy30JtinUApegLEQ?= =?us-ascii?Q?cIx3okYWqAsT5QkT3fwaUE6GQI0iOXGDPgSaQi0cfdgSXf2MLsB34YA0yvnO?= =?us-ascii?Q?qaNGxfZO4ZswYvZi5j+/H36wH+mn9LAjBgWUuGBZ7NNMehgh40gQQSjsRI6f?= =?us-ascii?Q?RzspB2pT/5T4heqgHhYuPG4ewsru3moa0D2A13wMg748YjWzkslOmvPJIRax?= =?us-ascii?Q?82oqLQ9XrGnNWjwP2yGicmkZ/fuHegFgeq6bVwkjKk7Yz7sO0fVUUxnS+6if?= =?us-ascii?Q?90ZoOVrwugEZNuG5PKpcJvqw2LK73jVVFPKXyqHmZyG6atv/h0Yet+P/09w2?= =?us-ascii?Q?CQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0c62f674-7489-4be2-f3a5-08ddb9b18ff0 X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB8427.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2025 21:44:03.3875 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WSVqiolHy1fKWyHJBrAr5j9XIejaEA0vKtk1Mym+/CgTeXezzSGtRBucnd0ww6R4IdDT7nTKNTsmpgvy3pKW8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8143 X-OriginatorOrg: intel.com X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, Jul 01, 2025 at 12:28:36PM -0000, Patchwork wrote: > == Series Details == > > Series: drm/xe: i2c support (rev6) > URL : https://patchwork.freedesktop.org/series/149699/ > State : warning > > == Summary == > > + KERNEL=/kernel > + git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt > Cloning into 'mt'... > warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/ > + git -C mt rev-list -n1 origin/master > f8ff75ae1d2127635239b134695774ed4045d05b > + cd /kernel > + git config --global --add safe.directory /kernel > + git log -n1 > commit 1fc9fee6df0e31f875d061c04a10c6a9b0abfe0b > Author: Riana Tauro > Date: Tue Jul 1 15:22:52 2025 +0300 > > drm/xe/xe_i2c: Add support for i2c in survivability mode > > Initialize i2c in survivability mode to allow firmware > update of Add-In Management Controller (AMC) in > survivability mode. > > Signed-off-by: Riana Tauro > Signed-off-by: Heikki Krogerus > Reviewed-by: Raag Jadav > Reviewed-by: Andi Shyti > + /mt/dim checkpatch 9f3690735949ad5f24ece89cf2e91c2750ea580f drm-intel > cf5044118b7c i2c: designware: Use polling by default when there is no irq resource > ca9127e99159 i2c: designware: Add quirk for Intel Xe > -:9: WARNING:BAD_SIGN_OFF: Non-standard signature: Originally-by: > #9: > Originally-by: Michael J. Ruhl > > total: 0 errors, 1 warnings, 0 checks, 24 lines checked > acd550ef8110 drm/xe: Support for I2C attached MCUs > -:14: WARNING:BAD_SIGN_OFF: Non-standard signature: Originally-by: > #14: > Originally-by: Michael J. Ruhl > > -:44: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? > #44: > new file mode 100644 > > -:153: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'drivers/gpu/drm/xe/xe_i2c.c', please use '//' instead > #153: FILE: drivers/gpu/drm/xe/xe_i2c.c:1: > +/* SPDX-License-Identifier: GPL-2.0 OR MIT */ Could you please fix this and resend? It should be // SPDX-License-Identifier: GPL-2.0 OR MIT in .c /**/ is correct in .h > > -:153: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 > #153: FILE: drivers/gpu/drm/xe/xe_i2c.c:1: > +/* SPDX-License-Identifier: GPL-2.0 OR MIT */ Here as well... > > total: 0 errors, 4 warnings, 0 checks, 457 lines checked > d4c211f8d91b drm/xe/pm: Wire up suspend/resume for I2C controller > 1fc9fee6df0e drm/xe/xe_i2c: Add support for i2c in survivability mode > >