From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 2/3] ata: libata-core: Make ata_dev_cleanup_cdl_resources() static
Date: Thu, 3 Jul 2025 11:20:19 +0200 [thread overview]
Message-ID: <aGZLU7eAbyagCTvb@ryzen> (raw)
In-Reply-To: <20250703071541.278243-3-dlemoal@kernel.org>
On Thu, Jul 03, 2025 at 04:15:40PM +0900, Damien Le Moal wrote:
> The function ata_dev_cleanup_cdl_resources() is called only from
> ata_dev_init_cdl_resources() and ata_dev_free_resources() which are
> both defined in drivers/ata/libata-core.c. So there is no need for
> ata_dev_cleanup_cdl_resources() to be visible from outside of this
> file. Change this function definition to be a static function.
>
> No functional changes.
>
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
next prev parent reply other threads:[~2025-07-03 9:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 7:15 [PATCH 0/3] Improve log directory handling and some cleanups Damien Le Moal
2025-07-03 7:15 ` [PATCH 1/3] ata: libata-core: Cache the general purpose log directory Damien Le Moal
2025-07-03 9:49 ` Niklas Cassel
2025-07-03 10:07 ` Damien Le Moal
2025-07-03 7:15 ` [PATCH 2/3] ata: libata-core: Make ata_dev_cleanup_cdl_resources() static Damien Le Moal
2025-07-03 9:20 ` Niklas Cassel [this message]
2025-07-03 7:15 ` [PATCH 3/3] ata: libata-eh: Rename and make ata_set_mode() static Damien Le Moal
2025-07-03 9:29 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGZLU7eAbyagCTvb@ryzen \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.