From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D844C83F1B for ; Thu, 10 Jul 2025 14:22:09 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uZs9X-0001PY-JS; Thu, 10 Jul 2025 10:21:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZs0R-0001tl-Jl for qemu-devel@nongnu.org; Thu, 10 Jul 2025 10:12:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZs0P-0004UR-4z for qemu-devel@nongnu.org; Thu, 10 Jul 2025 10:12:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752156727; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=u0qe4pZXWXTu5zop2sq6sWqbGNv19LlFm/2Cc3cn9Bs=; b=bd4raWlEsOQ3oeLUUIK3FtM1FkYeyh3Vd74gZRBhOeeUrmm3sx/+YBLbNK3IC4aBF6nZSD iGGu7plKqh2/rR5b8yVyIP5J7PfbrWOYJQZBMjNHv7RYtJERaOuUG9hU5hSEhRaCh2uFQB yFQsi2rbVkB0hTuu250TYLIJyGi1VW8= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-73-poQS5VaZMa-_g_6cAwuG7g-1; Thu, 10 Jul 2025 10:12:03 -0400 X-MC-Unique: poQS5VaZMa-_g_6cAwuG7g-1 X-Mimecast-MFC-AGG-ID: poQS5VaZMa-_g_6cAwuG7g_1752156722 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 984191809C91; Thu, 10 Jul 2025 14:12:02 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.76]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0B0F9180045B; Thu, 10 Jul 2025 14:12:00 +0000 (UTC) Date: Thu, 10 Jul 2025 15:11:57 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Xiaoyao Li Cc: Zhenzhong Duan , qemu-devel@nongnu.org, chao.p.peng@intel.com Subject: Re: [PATCH] i386/tdx: Fix the report of gpa in QAPI Message-ID: References: <20250710035538.303136-1-zhenzhong.duan@intel.com> <3b6c0344-0694-4a56-99dd-c7d437e43428@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Jul 10, 2025 at 10:06:10PM +0800, Xiaoyao Li wrote: > On 7/10/2025 7:40 PM, Xiaoyao Li wrote: > > On 7/10/2025 11:55 AM, Zhenzhong Duan wrote: > > > Gpa is defined in QAPI but never reported to monitor because has_gpa is > > > never set to ture. > > > > > > Fix it by setting has_gpa to ture when TDX_REPORT_FATAL_ERROR_GPA_VALID > > > is set in error_code. > > > > Hi Zhenzhong, > > > > I would like to understand what the problem is without panic_info- > > >u.tdx.has_gpa being set? > > Never mind, I figure it out. > > qapi_event_send_guest_panicked() in qemu_system_guest_panicked will send the > event and data. Libvirt tries to parse the data, but find the .has_data > field is not set correctly. Close, but not quite. The "has_" fields are only present in the QEMU internal data structures, never on the wire in the JSON messages that libvirt receives. The problem is with QEMU's struct -> JSON serialization - if the 'has_gpa' field is not set to 'true', then QEMU will *never* emit the 'gpa' field in the JSON it sends to the client app. So what libvirt receives is this: {"timestamp": {"seconds": 1752156518, "microseconds": 809325}, "event": "GUEST_PANICKED", "data": {"action": "pause", "info": { "error-code": 0, "message": "TD misconfiguration: SEPT #VE has to be disabled", "type": "tdx"}}} which has no 'gpa' present. > My original patch used (gpa == -1) as the indicator for whether gpa is > valid, this needs to be cleaned up. I will send the cleanup patch. The value you assign to 'gpa' doesn't matter when 'has_gpa' is false, as it'll never get into the JSON event, so having it be '-1' is not significantly different from leaving it on 0. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|