From: Alice Ryhl <aliceryhl@google.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: "Daniel Almeida" <daniel.almeida@collabora.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Benno Lossin" <lossin@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v5 3/6] rust: irq: add support for non-threaded IRQs and handlers
Date: Fri, 4 Jul 2025 07:29:11 +0000 [thread overview]
Message-ID: <aGeCx5zHUPKtaryg@google.com> (raw)
In-Reply-To: <92c347d7-4b59-436e-b4ce-5941bdc42cd8@kernel.org>
On Thu, Jul 03, 2025 at 08:49:07PM +0200, Danilo Krummrich wrote:
> On 7/3/25 7:12 PM, Daniel Almeida wrote:
> > > +/// Callbacks for an IRQ handler.
> > > +pub trait Handler: Sync {
> >
> > I wonder if we should require ’static here too?
> >
> > Same for the Threaded trait.
>
> You already have
>
> impl<T: Handler + 'static> Registration<T>
>
> which I think this is good enough.
If we're not going to support non-static handlers, then I think it's
simpler to place the 'static bound on the trait.
Alice
next prev parent reply other threads:[~2025-07-04 7:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 16:21 [PATCH v5 0/6] rust: add support for request_irq Daniel Almeida
2025-06-27 16:21 ` [PATCH v5 1/6] rust: irq: add irq module Daniel Almeida
2025-06-27 16:21 ` [PATCH v5 2/6] rust: irq: add flags module Daniel Almeida
2025-06-27 16:21 ` [PATCH v5 3/6] rust: irq: add support for non-threaded IRQs and handlers Daniel Almeida
2025-06-27 19:35 ` Danilo Krummrich
2025-07-03 17:12 ` Daniel Almeida
2025-07-03 18:49 ` Danilo Krummrich
2025-07-04 7:29 ` Alice Ryhl [this message]
2025-06-27 16:21 ` [PATCH v5 4/6] rust: irq: add support for threaded " Daniel Almeida
2025-06-27 19:31 ` Danilo Krummrich
2025-07-01 15:22 ` Daniel Almeida
2025-06-27 16:21 ` [PATCH v5 5/6] rust: platform: add irq accessors Daniel Almeida
2025-06-27 19:10 ` Danilo Krummrich
2025-06-27 19:14 ` Danilo Krummrich
2025-06-27 16:21 ` [PATCH v5 6/6] rust: pci: " Daniel Almeida
2025-06-27 16:29 ` [PATCH v5 0/6] rust: add support for request_irq Daniel Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGeCx5zHUPKtaryg@google.com \
--to=aliceryhl@google.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.