All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nf-next PATCH 0/3] netfilter: nf_tables: Report found devices when creating a netdev hook
Date: Fri, 4 Jul 2025 10:00:41 +0200	[thread overview]
Message-ID: <aGeKKXVmGjS2YVMu@calendula> (raw)
In-Reply-To: <20250612133416.18133-1-phil@nwl.cc>

On Thu, Jun 12, 2025 at 03:34:13PM +0200, Phil Sutter wrote:
> Previously, NEWDEV/DELDEV notifications were emitted for new/renamed
> devices added to a chain or flowtable only. For user space to fully
> comprehend which interfaces a hook binds to, these notifications have to
> be sent for matching devices at hook creation time, too.
> 
> This series extends the notify list to support messages for varying
> groups so it may be reused by the NFNLGRP_NFT_DEV messages (patch 1),
> adjusts the device_notify routines to support enqueueing the message
> instead of sending it right away (patch 2) and finally adds extra notify
> calls to nf_tables_commit() (patch 3).

Fine with these series, I am preparing a nf-next pull request, I plan
to include them.

As this goes ahead in providing NEWDEV/DELDEV events for ruleset
updates, I think GETDEV is needed to complete things.

Regarding userspace, I think there only one item remaining to be
discussed, which is how to expose device notifications.

I would suggest to add a separated:

        monitor devices

Thanks.

  parent reply	other threads:[~2025-07-04  8:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-12 13:34 [nf-next PATCH 0/3] netfilter: nf_tables: Report found devices when creating a netdev hook Phil Sutter
2025-06-12 13:34 ` [nf-next PATCH 1/3] netfilter: nf_tables: commit_notify: Support varying groups Phil Sutter
2025-06-12 13:34 ` [nf-next PATCH 2/3] netfilter: nf_tables: Support enqueueing device notifications Phil Sutter
2025-06-12 13:34 ` [nf-next PATCH 3/3] netfilter: nf_tables: Extend chain/flowtable notifications Phil Sutter
2025-07-04  8:00 ` Pablo Neira Ayuso [this message]
2025-07-04 13:18   ` [nf-next PATCH 0/3] netfilter: nf_tables: Report found devices when creating a netdev hook Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aGeKKXVmGjS2YVMu@calendula \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.