Re: [PATCH v2 07/24] migration: Add a flag to track block-bitmap-mapping input

[Peter Xu <peterx@redhat.com>]

On Mon, Jun 30, 2025 at 04:58:56PM -0300, Fabiano Rosas wrote:
> The QAPI converts an empty list on the block-bitmap-mapping input into
> a NULL BitmapMigrationNodeAliasList. The empty list is a valid input
> for the block-bitmap-mapping option, so commit 3cba22c9ad ("migration:
> Fix block_bitmap_mapping migration") started using the
> s->parameters.has_block_bitmap_mapping field to tell when the user has
> passed in an empty list vs. when no list has been passed at all.
> 
> Using s->parameters.has_block_bitmap_mapping field is only possible
> because MigrationParameters has had its members made optional due to
> historical reasons.
> 
> In order to make improvements to the way configuration options are set
> for a migration, we'd like to reduce the open-coded usage of the has_*
> fields of the global configuration object (s->parameters).
> 
> Add a separate boolean to track the status of the block_bitmap_mapping
> option.
> 
> No functional change intended.
> 
> (this was verified to not regress iotest 300, which is the test that
> 3cba22c9ad refers to)
> 
> CC: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>

Acked-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu