From: Zhao Liu <zhao1.liu@intel.com>
To: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-rust@nongnu.org,
"Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH 1/2] rust/qemu-api-macros: normalize TryInto output
Date: Fri, 4 Jul 2025 20:16:01 +0800 [thread overview]
Message-ID: <aGfGAcebpPS4UV3x@intel.com> (raw)
In-Reply-To: <20250704-rust_add_derive_macro_unit_tests-v1-1-ebd47fa7f78f@linaro.org>
On Fri, Jul 04, 2025 at 01:26:57PM +0300, Manos Pitsidianakis wrote:
> Date: Fri, 04 Jul 2025 13:26:57 +0300
> From: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
> Subject: [PATCH 1/2] rust/qemu-api-macros: normalize TryInto output
> X-Mailer: b4 0.14.2
>
> Remove extraneous `;` and add missing trailing comma to TryInto derive
> macro to match rustfmt style. We will add a test in the followup commit
> and we would like the inlined output in the test body to be properly
> formatted as well.
>
> No functional changes intended.
>
> Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
> ---
> rust/qemu-api-macros/src/lib.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
next prev parent reply other threads:[~2025-07-04 11:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 10:26 [PATCH 0/2] rust: add Derive macro unit tests Manos Pitsidianakis
2025-07-04 10:26 ` [PATCH 1/2] rust/qemu-api-macros: normalize TryInto output Manos Pitsidianakis
2025-07-04 12:16 ` Zhao Liu [this message]
2025-07-04 10:26 ` [PATCH 2/2] rust/qemu-api-macros: add unit tests Manos Pitsidianakis
2025-07-04 12:37 ` Zhao Liu
2025-07-04 12:35 ` [PATCH 0/2] rust: add Derive macro " Zhao Liu
2025-07-04 12:18 ` Manos Pitsidianakis
2025-07-08 9:59 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGfGAcebpPS4UV3x@intel.com \
--to=zhao1.liu@intel.com \
--cc=alex.bennee@linaro.org \
--cc=manos.pitsidianakis@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.