From: Florian Westphal <fw@strlen.de>
To: Zhongqiu Duan <dzq.aishenghu0@gmail.com>
Cc: coreteam@netfilter.org, netfilter-devel@vger.kernel.org,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Simon Horman <horms@kernel.org>,
Fernando Fernandez Mancera <ffmancera@riseup.net>
Subject: Re: [PATCH nft 1/3] src: make the mss and wscale fields optional for synproxy object
Date: Fri, 4 Jul 2025 14:27:21 +0200 [thread overview]
Message-ID: <aGfIqX2im5ut1WNn@strlen.de> (raw)
In-Reply-To: <20250704113947.676-2-dzq.aishenghu0@gmail.com>
Zhongqiu Duan <dzq.aishenghu0@gmail.com> wrote:
> The mss and wscale fields is optional for synproxy statement, this patch
> to make the same behavior for synproxy object, and also makes the
> timestamp and sack-perm flags no longer order-sensitive.
Whats the use case for omitting the mss field?
It seems this should be made mandatory, no?
Also I think we should reject wscale > 14 from the parsers (can be done
in extra patch).
And also reject it in kernel by updating the nla_policy in
net/netfiler/nft_synproxy.c in the kernel.
next prev parent reply other threads:[~2025-07-04 12:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 11:39 [PATCH nft 0/3] make the mss and wscale fields optional for synproxy object Zhongqiu Duan
2025-07-04 11:39 ` [PATCH nft 1/3] src: " Zhongqiu Duan
2025-07-04 12:27 ` Florian Westphal [this message]
2025-07-04 14:46 ` Zhongqiu Duan
2025-07-04 11:39 ` [PATCH nft 2/3] src: do not print unnecessary space for the " Zhongqiu Duan
2025-07-04 14:56 ` Zhongqiu Duan
2025-07-04 11:39 ` [PATCH nft 3/3] src: only print the mss and wscale of synproxy if they are present Zhongqiu Duan
2025-07-04 11:54 ` Florian Westphal
2025-07-04 12:11 ` Zhongqiu Duan
2025-07-04 12:21 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGfIqX2im5ut1WNn@strlen.de \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=dzq.aishenghu0@gmail.com \
--cc=ffmancera@riseup.net \
--cc=horms@kernel.org \
--cc=kadlec@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.