From: Raag Jadav <raag.jadav@intel.com>
To: "André Almeida" <andrealmeid@igalia.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
airlied@gmail.com, simona@ffwll.ch,
Krzysztof Karas <krzysztof.karas@intel.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kernel-dev@igalia.com
Subject: Re: [PATCH v3 2/3] drm: Add missing struct drm_wedge_task_info kernel doc
Date: Fri, 4 Jul 2025 21:47:50 +0300 [thread overview]
Message-ID: <aGgh1vYPsAmexvOn@black.fi.intel.com> (raw)
In-Reply-To: <20250627171715.438304-2-andrealmeid@igalia.com>
On Fri, Jun 27, 2025 at 02:17:14PM -0300, André Almeida wrote:
> Fix the following kernel doc warning:
>
> include/drm/drm_device.h:40: warning: Function parameter or struct member 'pid' not described in 'drm_wedge_task_info'
> include/drm/drm_device.h:40: warning: Function parameter or struct member 'comm' not described in 'drm_wedge_task_info'
>
> Fixes: 183bccafa176 ("drm: Create a task info option for wedge events")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: André Almeida <andrealmeid@igalia.com>
> ---
> v3: Make it consistent with drm_device member description
> v2: Add Reported-by tag
> ---
> include/drm/drm_device.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/drm/drm_device.h b/include/drm/drm_device.h
> index 08b3b2467c4c..73dd3c5470a4 100644
> --- a/include/drm/drm_device.h
> +++ b/include/drm/drm_device.h
> @@ -35,7 +35,9 @@ struct pci_controller;
> * struct drm_wedge_task_info - information about the guilty task of a wedge dev
> */
> struct drm_wedge_task_info {
> + /** @pid: the pid of the task */
Nit: Can be simply "pid of the task" without initial "the".
> pid_t pid;
> + /** @comm: the command name of the task */
Ditto.
> char comm[TASK_COMM_LEN];
But in any case,
Reviewed-by: Raag Jadav <raag.jadav@intel.com>
next prev parent reply other threads:[~2025-07-04 18:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 17:17 [PATCH v3 1/3] drm/doc: Fix title underline for "Task information" André Almeida
2025-06-27 17:17 ` [PATCH v3 2/3] drm: Add missing struct drm_wedge_task_info kernel doc André Almeida
2025-07-04 18:47 ` Raag Jadav [this message]
2025-06-27 17:17 ` [PATCH v3 3/3] drm/doc: Fix grammar for "Task information" André Almeida
2025-07-04 18:49 ` Raag Jadav
2025-07-04 16:46 ` [PATCH v3 1/3] drm/doc: Fix title underline " André Almeida
2025-07-04 18:26 ` Raag Jadav
2025-07-04 18:41 ` Raag Jadav
2025-07-04 18:49 ` André Almeida
2025-07-04 18:54 ` Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGgh1vYPsAmexvOn@black.fi.intel.com \
--to=raag.jadav@intel.com \
--cc=airlied@gmail.com \
--cc=andrealmeid@igalia.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-dev@igalia.com \
--cc=krzysztof.karas@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.