All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Will Deacon <will@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"Luis Claudio R . Goncalves" <lgoncalv@redhat.com>,
	linux-arm-kernel@lists.infradead.org,
	Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: [PATCH v5 10/13] arm64: debug: split hardware watchpoint exception entry
Date: Sun, 6 Jul 2025 19:46:33 -0500	[thread overview]
Message-ID: <aGsY6c4syByZQ8cr@arm.com> (raw)
In-Reply-To: <aGgQI4c7MFmQ48tI@willie-the-truck>

On Fri, Jul 04, 2025 at 06:32:19PM +0100, Will Deacon wrote:
> On Fri, Jun 27, 2025 at 06:20:35PM +0100, Ada Couprie Diaz wrote:
> > +static void noinstr el1_dbg(struct pt_regs *regs, unsigned long esr)
> > +{
> >  	arm64_enter_el1_dbg(regs);
> >  	if (!cortex_a76_erratum_1463225_debug_handler(regs))
> >  		do_debug_exception(far, esr, regs);
> 
> This leads to:
> 
> Failed to build patch #10: 0d0a8f024a19 arm64: debug: split hardware watchpoint exception entry
> arch/arm64/kernel/entry-common.c: In function ‘el1_dbg’:
> arch/arm64/kernel/entry-common.c:572:36: error: ‘far’ undeclared (first use in this function)
>   572 |                 do_debug_exception(far, esr, regs);
>       |                                    ^~~
> 
> 
> Catalin -- do you reckon we should fix this? It's only this series
> sitting on for-next/debug-entry, nobody has pulled it afaik and we still
> have plenty of time before the merge window so a rebase probably won't
> hurt anybody.

Works for me, no-one pulled this branch and rely on it being stable. If
Ada sends a fixup, I can fold it into this patch or merge a new series
altogether if more patches are affected (or you can do it I don't get to
a reasonable wifi location in the next few days).

Thanks.

-- 
Catalin


  reply	other threads:[~2025-07-07  0:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-27 17:20 [PATCH v5 00/13] arm64: debug: remove hook registration, split exception entry Ada Couprie Diaz
2025-06-27 17:20 ` [PATCH v5 01/13] arm64: debug: clean up single_step_handler logic Ada Couprie Diaz
2025-06-27 17:20 ` [PATCH v5 02/13] arm64: refactor aarch32_break_handler() Ada Couprie Diaz
2025-06-27 17:20 ` [PATCH v5 03/13] arm64: debug: call software breakpoint handlers statically Ada Couprie Diaz
2025-06-27 17:20 ` [PATCH v5 04/13] arm64: debug: call step " Ada Couprie Diaz
2025-06-27 17:20 ` [PATCH v5 05/13] arm64: debug: remove break/step handler registration infrastructure Ada Couprie Diaz
2025-06-27 17:20 ` [PATCH v5 06/13] arm64: entry: Add entry and exit functions for debug exceptions Ada Couprie Diaz
2025-06-27 17:20 ` [PATCH v5 07/13] arm64: debug: split hardware breakpoint exception entry Ada Couprie Diaz
2025-06-27 17:20 ` [PATCH v5 08/13] arm64: debug: refactor reinstall_suspended_bps() Ada Couprie Diaz
2025-06-27 17:20 ` [PATCH v5 09/13] arm64: debug: split single stepping exception entry Ada Couprie Diaz
2025-06-27 17:20 ` [PATCH v5 10/13] arm64: debug: split hardware watchpoint " Ada Couprie Diaz
2025-07-04 17:32   ` Will Deacon
2025-07-07  0:46     ` Catalin Marinas [this message]
2025-07-07 11:48       ` Ada Couprie Diaz
2025-07-08 12:16       ` Will Deacon
2025-06-27 17:20 ` [PATCH v5 11/13] arm64: debug: split brk64 " Ada Couprie Diaz
2025-06-27 17:20 ` [PATCH v5 12/13] arm64: debug: split bkpt32 " Ada Couprie Diaz
2025-06-27 17:20 ` [PATCH v5 13/13] arm64: debug: remove debug exception registration infrastructure Ada Couprie Diaz
2025-07-02 10:26 ` [PATCH v5 00/13] arm64: debug: remove hook registration, split exception entry Mark Rutland
2025-07-02 18:34 ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aGsY6c4syByZQ8cr@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=anshuman.khandual@arm.com \
    --cc=lgoncalv@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.