Re: [bug report] [PATCH v6] net: usb: Convert tasklet API to new bottom half workqueue mechanism

[Oleksij Rempel <o.rempel@pengutronix.de>]

Hello, Zqiang

On Sat, Jul 05, 2025 at 06:41:20AM +0000, qiang.zhang@linux.dev wrote:
> > Hello, Oleksij
> > 
> > Please try follow patch base on Jun Miao's patchs:
> > 
> 
> Sorry, please ignore previous, try it:
> 
> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
> index 9564478a79cc..6a3cca104af9 100644
> --- a/drivers/net/usb/usbnet.c
> +++ b/drivers/net/usb/usbnet.c
> @@ -861,14 +861,14 @@ int usbnet_stop (struct net_device *net)
>         /* deferred work (timer, softirq, task) must also stop */
>         dev->flags = 0;
>         timer_delete_sync(&dev->delay);
> -       disable_work_sync(&dev->bh_work);
> +       cancel_work_sync(&dev->bh_work);
>         cancel_work_sync(&dev->kevent);
>  
>         /* We have cyclic dependencies. Those calls are needed
>          * to break a cycle. We cannot fall into the gaps because
>          * we have a flag
>          */
> -       disable_work_sync(&dev->bh_work);
> +       cancel_work_sync(&dev->bh_work);
>         timer_delete_sync(&dev->delay);
>         cancel_work_sync(&dev->kevent);

It seems to work now, thank you!
Tested on LAN9512 and ASIX AX88772B.

You can add my:
Reported-by: Oleksij Rempel <o.rempel@pengutronix.de>
Tested-by: Oleksij Rempel <o.rempel@pengutronix.de>

Best Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |