Re: [PATCH 6.12.y-cip 00/18] Add Support for RZ/G3E ICU

[Pavel Machek <pavel@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 1713 bytes --]

On Mon 2025-07-07 10:49:15, Tommaso Merciai wrote:
> Hi Pavel,
> Thanks for your work!
> 
> On Fri, Jul 04, 2025 at 08:12:56PM +0200, Pavel Machek wrote:
> > Hi!
> > 
> > > This series adds support for the RZ/G3E ICU driver into linux 6.12.y-cip.
> > > 
> > > The ICU block on the RZ/G3E SoC is almost identical to the one found on
> > > the RZ/V2H SoC, with the following differences:
> > >  - The TINT register base offset is 0x800 instead of zero.
> > >  - The number of supported GPIO interrupts for TINT selection is 141
> > >    instead of 86.
> > >  - The pin index and TINT selection index are not in the 1:1 map
> > >  - The number of TSSR registers is 16 instead of 8
> > >  - Each TSSR register can program 2 TINTs instead of 4 TINTs
> > > 
> > > This series applies on top of [1]
> > > 
> > > [1] https://patchwork.kernel.org/project/cip-dev/list/?series=978150&state=%2A&archive=both
> > 
> > Series looks ok to me.
> > 
> > I'll have some minor comments but nothing that should prevent
> > merge... so I can merge this if it passes testing and there are no
> > other comments.
> > 
> > One thing: "Signed-off-by:" section should not have empty lines in
> > that. I guess we can fix that up doing merge.
> 
> Sorry for that and thanks for taking care of this.
> Tbh I'm just using "git commit -s" to apply upstream patches.
> Any suggestion? Thanks in advance.
> 
> Maybe I have somenthing wrong in my configuration :'(

I guess git rebase -i to manually edit the changelogs is easiest
option there.

Best regards,
								Pavel
-- 
In cooperation with DENX Software Engineering GmbH, HRB 165235 Munich,
Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]