All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 4/8] Add ioctl_pidfd02 test
Date: Mon, 7 Jul 2025 17:37:27 +0200	[thread overview]
Message-ID: <aGvptwZtV26Dj7e_@yuki.lan> (raw)
In-Reply-To: <7080e0b9-2d4a-41b4-8566-c7afcc694bfe@suse.com>

Hi!
> > Looking at the kernel code it looks that if the PIDFD_INFO_EXIT is not
> > supported we will get ESRCH in the second case. So I suppose that better
> > fix would be to allow ESRCH in the second case if kernel is older than
> > 6.15 instead of skipping the whole test.
> 
> Maybe it makes more sense to check PIDFD_INFO_EXIT is available via 
> configure.ac and eventually check for this support in the setup(). So we 
> avoid weird runtime checks. WDYT?

And if you think about checking PIDFD_INFO_EXIT in the test setup() that
may be doable. But there is no need for configure checks in that case,
we just use PIDFD_INFO_EXIT fallback definition from the lapi headers.

I suppose adding a check for support that would be called if kernel
version is older than 6.15 would work as well.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2025-07-07 15:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-04 11:30 [LTP] [PATCH v2 0/8] ioctl_pidfd testing suite Andrea Cervesato
2025-07-04 11:30 ` [LTP] [PATCH v2 1/8] Provide pidfd parameter in tst_clone_args Andrea Cervesato
2025-07-07 11:44   ` Cyril Hrubis
2025-07-04 11:30 ` [LTP] [PATCH v2 2/8] Fallback PIDFD_GET_INFO related definitions Andrea Cervesato
2025-07-07 11:48   ` Cyril Hrubis
2025-07-04 11:30 ` [LTP] [PATCH v2 3/8] Add ioctl_pidfd01 test Andrea Cervesato
2025-07-07 12:00   ` Cyril Hrubis
2025-07-04 11:30 ` [LTP] [PATCH v2 4/8] Add ioctl_pidfd02 test Andrea Cervesato
2025-07-07 12:33   ` Cyril Hrubis
2025-07-07 15:25     ` Andrea Cervesato via ltp
2025-07-07 15:28     ` Andrea Cervesato via ltp
2025-07-07 15:31       ` Cyril Hrubis
2025-07-07 15:39         ` Cyril Hrubis
2025-07-07 15:37       ` Cyril Hrubis [this message]
2025-07-07 16:04         ` Andrea Cervesato via ltp
2025-07-07 16:06         ` Andrea Cervesato via ltp
2025-07-04 11:30 ` [LTP] [PATCH v2 5/8] Add ioctl_pidfd03 test Andrea Cervesato
2025-07-07 12:44   ` Cyril Hrubis
2025-07-04 11:30 ` [LTP] [PATCH v2 6/8] Add ioctl_pidfd04 test Andrea Cervesato
2025-07-07 12:56   ` Cyril Hrubis
2025-07-04 11:30 ` [LTP] [PATCH v2 7/8] Add ioctl_pidfd05 test Andrea Cervesato
2025-07-07 13:16   ` Cyril Hrubis
2025-07-04 11:30 ` [LTP] [PATCH v2 8/8] Add ioctl_pidfd06 test Andrea Cervesato
2025-07-07 13:27   ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aGvptwZtV26Dj7e_@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=andrea.cervesato@suse.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.