From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 0/2] src: add conntrack information to trace monitor mode
Date: Mon, 7 Jul 2025 22:14:59 +0200 [thread overview]
Message-ID: <aGwqw6OVzDCJhb26@calendula> (raw)
In-Reply-To: <aGwf3dCggwBlRKKC@strlen.de>
On Mon, Jul 07, 2025 at 09:28:29PM +0200, Florian Westphal wrote:
> diff --git a/src/trace.c b/src/trace.c
> index b270951025b8..b3b2c8fdf1b9 100644
> --- a/src/trace.c
> +++ b/src/trace.c
> @@ -264,7 +264,7 @@ static struct expr *trace_alloc_list(const struct datatype *dtype,
> for (i = 0; i < 32; i++) {
> uint32_t bitv = v & (1 << i);
>
> - if (bitv == 0)
> + if (bitv == 0 || i == IPS_UNTRACKED_BIT)
> continue;
>
> and remove the IPS_UNTRACKED_BIT from the symbol table.
>
> Then followup with a kernel patch that removes IPS_UNTRACKED_BIT before
> dumping ct->status.
>
> Does that sound ok?
Yes, let's keep it back until there is a clear use-case for this,
either not exposing it or promoting it as a first class citizen.
> If so, I'll apply the first patch in this series before resending 2/2.
Thanks.
prev parent reply other threads:[~2025-07-07 20:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 9:47 [PATCH nft 0/2] src: add conntrack information to trace monitor mode Florian Westphal
2025-07-07 9:47 ` [PATCH nft 1/2] src: split monitor trace code into new trace.c Florian Westphal
2025-07-07 20:13 ` Pablo Neira Ayuso
2025-07-07 9:47 ` [PATCH nft 2/2] src: add conntrack information to trace monitor mode Florian Westphal
2025-07-07 19:02 ` [PATCH nft 0/2] " Pablo Neira Ayuso
2025-07-07 19:28 ` Florian Westphal
2025-07-07 20:14 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGwqw6OVzDCJhb26@calendula \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.