All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiang Mei <xmei5@asu.edu>
To: Jakub Kicinski <kuba@kernel.org>
Cc: xiyou.wangcong@gmail.com, netdev@vger.kernel.org,
	gregkh@linuxfoundation.org, jhs@mojatatu.com, jiri@resnulli.us,
	security@kernel.org
Subject: Re: [PATCH v1] net/sched: sch_qfq: Fix race condition on qfq_aggregate
Date: Mon, 7 Jul 2025 16:42:42 -0700	[thread overview]
Message-ID: <aGxbckKft4_VxmMe@xps> (raw)
In-Reply-To: <20250707105833.0c6926dc@kernel.org>

On Mon, Jul 07, 2025 at 10:58:33AM -0700, Jakub Kicinski wrote:
> On Sat,  5 Jul 2025 15:39:58 -0700 Xiang Mei wrote:
> > A race condition can occur when 'agg' is modified in qfq_change_agg
> > (called during qfq_enqueue) while other threads access it
> > concurrently. For example, qfq_dump_class may trigger a NULL
> > dereference, and qfq_delete_class may cause a use-after-free.
> 
> Please don't post patches in reply to threads.

Thanks for the reminder. I'll remember it.
> Add a link to the thread using the Link: marker instead.
> You're also missing a Fixes tag here.

Also, thanks for the "Fixes" tag suggestion.
I read some documents introducing the Fixes tag, but I find it 
hard to find a Fixes commit since it's a design issue 
(lack of lock implementation on agg).

  reply	other threads:[~2025-07-07 23:42 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAPpSM+SKOj9U8g_QsGp8M45dtEwvX4B_xdd7C0mP9pYu1b4mzA@mail.gmail.com>
2025-06-29 14:28 ` sch_qfq: race conditon on qfq_aggregate (net/sched/sch_qfq.c) Jamal Hadi Salim
2025-06-30  3:11   ` Xiang Mei
2025-06-30 11:36     ` Jamal Hadi Salim
2025-06-30 18:49       ` Xiang Mei
2025-06-30 23:09         ` Cong Wang
2025-07-01  2:52           ` Xiang Mei
2025-07-02 19:41           ` Xiang Mei
2025-07-04  4:55             ` Cong Wang
2025-07-05 22:39               ` [PATCH v1] net/sched: sch_qfq: Fix race condition on qfq_aggregate Xiang Mei
2025-07-05 22:49                 ` Xiang Mei
2025-07-07 18:05                   ` Cong Wang
2025-07-07 17:58                 ` Jakub Kicinski
2025-07-07 23:42                   ` Xiang Mei [this message]
2025-07-08  0:20                     ` Jakub Kicinski
2025-07-07 18:03                 ` Cong Wang
2025-07-08  0:05                   ` Xiang Mei
2025-07-08  3:18                     ` Willy Tarreau
2025-07-09 18:08                       ` Xiang Mei
2025-07-09 18:06                   ` [PATCH v2] " Xiang Mei
2025-07-09 20:19                     ` Jakub Kicinski
2025-07-09 21:41                       ` Xiang Mei
2025-07-09 21:54                         ` Jakub Kicinski
2025-07-10 10:06                           ` Xiang Mei
2025-07-10 21:18                         ` Cong Wang
2025-07-10 22:45                           ` Xiang Mei
2025-07-01 14:02         ` sch_qfq: race conditon on qfq_aggregate (net/sched/sch_qfq.c) Jamal Hadi Salim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aGxbckKft4_VxmMe@xps \
    --to=xmei5@asu.edu \
    --cc=gregkh@linuxfoundation.org \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=security@kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.