From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, eblake@redhat.com, pbonzini@redhat.com,
eduardo@habkost.net, steven.sistare@oracle.com
Subject: Re: [PATCH 1/2] qapi: Clean up "This command will do ..." command descriptions
Date: Tue, 8 Jul 2025 08:50:43 +0100 [thread overview]
Message-ID: <aGzNvhiIZh0JZo0M@redhat.com> (raw)
In-Reply-To: <20250708072828.105185-2-armbru@redhat.com>
On Tue, Jul 08, 2025 at 09:28:27AM +0200, Markus Armbruster wrote:
> Use imperative mood "Do ..." instead.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qapi/control.json | 9 +++++----
> qapi/misc-i386.json | 11 +++++------
> qapi/qom.json | 10 ++++------
> 3 files changed, 14 insertions(+), 16 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-07-08 20:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 7:28 [PATCH 0/2] qapi: Minor documentation cleanups Markus Armbruster
2025-07-08 7:28 ` [PATCH 1/2] qapi: Clean up "This command will do ..." command descriptions Markus Armbruster
2025-07-08 7:50 ` Daniel P. Berrangé [this message]
2025-07-08 7:28 ` [PATCH 2/2] qapi: Clean up a few Errors: sections Markus Armbruster
2025-07-08 7:51 ` Daniel P. Berrangé
2025-07-11 17:35 ` [PATCH 0/2] qapi: Minor documentation cleanups Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGzNvhiIZh0JZo0M@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=steven.sistare@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.