All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: "Ahmed S. Darwish" <darwi@linutronix.de>
Cc: Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@redhat.com>,
	 Dave Hansen <dave.hansen@linux.intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	 Andrew Cooper <andrew.cooper3@citrix.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	 Vitaly Kuznetsov <vkuznets@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	John Ogness <john.ogness@linutronix.de>,
	x86@kernel.org,  kvm@vger.kernel.org, x86-cpuid@lists.linux.dev,
	 LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/6] x86: Reorder headers alphabetically
Date: Tue, 22 Jul 2025 07:18:17 -0700	[thread overview]
Message-ID: <aH-dqcMWj3cFDos2@google.com> (raw)
In-Reply-To: <20250722065448.413503-4-darwi@linutronix.de>

On Tue, Jul 22, 2025, Ahmed S. Darwish wrote:
> Multiple x86 source files use the cpuid_*() macros, but implicitly
> include the main CPUID API header.
> 
> Sort their include lines so that <asm/cpuid/api.h> can be explicitly
> included next.
> 
> Signed-off-by: Ahmed S. Darwish <darwi@linutronix.de>
> ---
>  arch/x86/boot/startup/sme.c           |  8 +--
>  arch/x86/coco/tdx/tdx.c               |  5 +-
>  arch/x86/events/amd/uncore.c          | 14 +++---
>  arch/x86/events/zhaoxin/core.c        | 11 ++---
>  arch/x86/kernel/apic/apic.c           | 70 +++++++++++++--------------
>  arch/x86/kernel/cpu/amd.c             | 25 +++++-----
>  arch/x86/kernel/cpu/mce/core.c        | 62 ++++++++++++------------
>  arch/x86/kernel/cpu/microcode/amd.c   | 12 ++---
>  arch/x86/kernel/cpu/microcode/core.c  | 22 ++++-----
>  arch/x86/kernel/cpu/microcode/intel.c | 11 +++--
>  arch/x86/kernel/cpu/mshyperv.c        | 28 ++++++-----
>  arch/x86/kernel/cpu/resctrl/core.c    |  5 +-
>  arch/x86/kernel/cpu/scattered.c       |  2 +-
>  arch/x86/kernel/cpu/topology_common.c |  2 +-
>  arch/x86/kernel/cpu/vmware.c          | 13 ++---
>  arch/x86/kernel/jailhouse.c           |  9 ++--
>  arch/x86/kernel/kvm.c                 | 35 +++++++-------
>  arch/x86/kernel/paravirt.c            | 28 +++++------
>  arch/x86/kvm/mmu/mmu.c                | 56 ++++++++++-----------
>  arch/x86/kvm/svm/sev.c                | 25 +++++-----
>  arch/x86/kvm/svm/svm.c                | 50 +++++++++----------
>  arch/x86/kvm/vmx/pmu_intel.c          |  6 ++-
>  arch/x86/kvm/vmx/sgx.c                |  2 +-
>  arch/x86/kvm/vmx/vmx.c                | 18 +++----

If this series is squeezed into Linus' tree just before rc1, I suppose I'm fine
with this patch.  But I am NOT providing an ack for general inclusion, because
the potential for pain is not worth the warm fuzzies we get by having sorted
includes.

  reply	other threads:[~2025-07-22 14:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-22  6:54 [PATCH v3 0/6] x86: Disentangle <asm/processor.h> dependency on CPUID headers Ahmed S. Darwish
2025-07-22  6:54 ` [PATCH v3 1/6] x86/cpuid: Remove transitional <asm/cpuid.h> header Ahmed S. Darwish
2025-07-22  6:54 ` [PATCH v3 2/6] ASoC: Intel: avs: Include CPUID header at file scope Ahmed S. Darwish
2025-07-22  6:54 ` [PATCH v3 3/6] x86: Reorder headers alphabetically Ahmed S. Darwish
2025-07-22 14:18   ` Sean Christopherson [this message]
2025-07-22  6:54 ` [PATCH v3 4/6] drivers: " Ahmed S. Darwish
2025-07-22  6:54 ` [PATCH v3 5/6] treewide: Explicitly include the x86 CPUID headers Ahmed S. Darwish
2025-07-22  6:54 ` [PATCH v3 6/6] x86/cpu: <asm/processor.h>: Do not include the CPUID API header Ahmed S. Darwish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aH-dqcMWj3cFDos2@google.com \
    --to=seanjc@google.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=darwi@linutronix.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jgross@suse.com \
    --cc=john.ogness@linutronix.de \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=vkuznets@redhat.com \
    --cc=x86-cpuid@lists.linux.dev \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.